Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4067)

Unified Diff: chrome/renderer/chrome_render_process_observer.h

Issue 700953002: Send all field trials from the browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@finch4
Patch Set: Responded to comments. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/chrome_render_process_observer.h
diff --git a/chrome/renderer/chrome_render_process_observer.h b/chrome/renderer/chrome_render_process_observer.h
index 75d8415e3997d53fade3b2cf2047456ffe085501..ff51d6f6c6be74de3aff2b8996e4ae5d6fc23fd1 100644
--- a/chrome/renderer/chrome_render_process_observer.h
+++ b/chrome/renderer/chrome_render_process_observer.h
@@ -10,6 +10,7 @@
#include "base/compiler_specific.h"
#include "base/files/file_path.h"
#include "base/memory/scoped_ptr.h"
+#include "base/metrics/field_trial.h"
#include "components/content_settings/core/common/content_settings.h"
#include "content/public/renderer/render_process_observer.h"
@@ -25,7 +26,8 @@ class ResourceDispatcherDelegate;
// a RenderView) for Chrome specific messages that the content layer doesn't
// happen. If a few messages are related, they should probably have their own
// observer.
-class ChromeRenderProcessObserver : public content::RenderProcessObserver {
+class ChromeRenderProcessObserver : public content::RenderProcessObserver,
+ public base::FieldTrialList::Observer {
public:
explicit ChromeRenderProcessObserver(
ChromeContentRendererClient* client);
@@ -51,7 +53,8 @@ class ChromeRenderProcessObserver : public content::RenderProcessObserver {
void OnSetFieldTrialGroup(const std::string& fiel_trial_name,
const std::string& group_name);
void OnGetV8HeapStats();
-
+ void OnFieldTrialGroupFinalized(const std::string& trial_name,
+ const std::string& group_name) override;
Alexei Svitkine (slow) 2014/11/05 22:50:53 Nit: Leave an empty line before the start of field
Georges Khalil 2014/11/06 18:36:28 Done.
static bool is_incognito_process_;
scoped_ptr<content::ResourceDispatcherDelegate> resource_delegate_;
ChromeContentRendererClient* client_;

Powered by Google App Engine
This is Rietveld 408576698