Send all field trials from the browser.

base/metrics/field_trial.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/metrics/field_trial.h"
 
 #include <algorithm>
 
 #include "base/build_time.h"
 #include "base/logging.h"
@@ skipping 205 matching lines @@
 
 bool FieldTrial::GetActiveGroup(ActiveGroup* active_group) const {
   if (!group_reported_ || !enable_field_trial_)
     return false;
   DCHECK_NE(group_, kNotFinalized);
   active_group->trial_name = trial_name_;
   active_group->group_name = group_name_;
   return true;
 }
 
+bool FieldTrial::GetFieldTrialState(FieldTrialState* field_trial_state) const {
+  if (!enable_field_trial_)
+    return false;
+  field_trial_state->trial_name = trial_name_;
+  field_trial_state->group_name = group_name_;
+  field_trial_state->activated = group_reported_;
+  return true;
+}
+
 //------------------------------------------------------------------------------
 // FieldTrialList methods and members.
 
 // static
 FieldTrialList* FieldTrialList::global_ = NULL;
 
 // static
 bool FieldTrialList::used_without_global_ = false;
 
 FieldTrialList::Observer::~Observer() {
@@ skipping 144 matching lines @@
     DCHECK_EQ(std::string::npos,
               it->group_name.find(kPersistentStringSeparator));
     output->append(it->trial_name);
     output->append(1, kPersistentStringSeparator);
     output->append(it->group_name);
     output->append(1, kPersistentStringSeparator);
   }
 }
 
 // static
+void FieldTrialList::AllStatesToString(std::string* output) {
+  FieldTrial::AllGroups all_groups;
+  GetAllFieldTrialGroups(&all_groups);
+  for (const FieldTrial::FieldTrialState& trial : all_groups) {
+    DCHECK_EQ(std::string::npos,
+              trial.trial_name.find(kPersistentStringSeparator));
+    DCHECK_EQ(std::string::npos,
+              trial.group_name.find(kPersistentStringSeparator));
+    if (trial.activated)
+      output->append(1, kActivationMarker);
+    output->append(trial.trial_name);
+    output->append(1, kPersistentStringSeparator);
+    output->append(trial.group_name);
+    output->append(1, kPersistentStringSeparator);
+  }
+}
+
+// static
 void FieldTrialList::GetActiveFieldTrialGroups(
     FieldTrial::ActiveGroups* active_groups) {
   DCHECK(active_groups->empty());
   if (!global_)
     return;
   AutoLock auto_lock(global_->lock_);
 
   for (RegistrationMap::iterator it = global_->registered_.begin();
        it != global_->registered_.end(); ++it) {
     FieldTrial::ActiveGroup active_group;
     if (it->second->GetActiveGroup(&active_group))
       active_groups->push_back(active_group);
   }
 }
 
 // static
+void FieldTrialList::GetAllFieldTrialGroups(

[Alexei Svitkine (slow), 2014/11/05 22:50:53]

Hmm, actually if this method is private, I suggest not to have it at all and
just inline this into the AllStatesToString() implementation. i.e. that function
can iterate directly over global_->registered_.

[Georges Khalil, 2014/11/06 18:36:28]

Done.

+    FieldTrial::AllGroups* all_groups) {
+  DCHECK(all_groups->empty());
+  if (!global_)
+    return;
+  AutoLock auto_lock(global_->lock_);
+
+  for (const auto& it : global_->registered_) {

[Alexei Svitkine (slow), 2014/11/05 22:50:53]

Nit: I prefer to explicitly name the type for clarity and name it something
other than it, e.g.:

 for (const FieldTrial& trial : global_->registered_) {

[Georges Khalil, 2014/11/06 18:36:28]

Type is std::pair<string, base::FieldTrial *> and caused indentation issue,
hence the use of auto.

+    FieldTrial::FieldTrialState field_trial_state;
+    if (it.second->GetFieldTrialState(&field_trial_state))
+      all_groups->push_back(field_trial_state);
+  }
+}
+
+// static
 bool FieldTrialList::CreateTrialsFromString(
     const std::string& trials_string,
     FieldTrialActivationMode mode,
     const std::set<std::string>& ignored_trial_names) {
   DCHECK(global_);
   if (trials_string.empty() || !global_)
     return true;
 
   size_t next_item = 0;
   while (next_item < trials_string.length()) {
@@ skipping 132 matching lines @@
     return;
   }
   AutoLock auto_lock(global_->lock_);
   DCHECK(!global_->PreLockedFind(trial->trial_name()));
   trial->AddRef();
   trial->SetTrialRegistered();
   global_->registered_[trial->trial_name()] = trial;
 }
 
 }  // namespace base