Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 700943005: Send coverage VA as floats instead of bytes (Closed)

Created:
6 years, 1 month ago by egdaniel
Modified:
6 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Send coverage VA as floats instead of bytes NOTREECHECKS=True BUG=skia: Committed: https://skia.googlesource.com/skia/+/e27065ae243575f6d5d545909ad3030773c14db8

Patch Set 1 #

Patch Set 2 : Use floats instead of scalars #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -29 lines) Patch
M include/gpu/GrColor.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 5 chunks +8 lines, -6 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 1 6 chunks +16 lines, -21 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
egdaniel
ptal. The test timings from the first patch on CL show the timings dropping back ...
6 years, 1 month ago (2014-11-06 15:35:22 UTC) #2
bsalomon
lgtm
6 years, 1 month ago (2014-11-06 15:49:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/700943005/20001
6 years, 1 month ago (2014-11-06 15:50:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/700943005/20001
6 years, 1 month ago (2014-11-06 16:00:40 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-06 16:00:52 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as e27065ae243575f6d5d545909ad3030773c14db8

Powered by Google App Engine
This is Rietveld 408576698