Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Issue 700923003: testserver.py: Remove log spam that would print on most requests. (Closed)

Created:
6 years, 1 month ago by ncarter (slow)
Modified:
6 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

testserver.py: Remove log spam that would print on most requests. The ShouldHandleRequest call in the handlers is just the prefix matching, implementing a filter-chain pattern, and failure is normal. BUG=None TBR=phajdan.jr@chromium.org Committed: https://crrev.com/0b789ef8f4f2b7ff37137f650525c5c6044b7bf7 Cr-Commit-Position: refs/heads/master@{#302692}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M net/tools/testserver/testserver.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
ncarter (slow)
6 years, 1 month ago (2014-11-04 18:49:13 UTC) #2
ncarter (slow)
Nasko, please review
6 years, 1 month ago (2014-11-04 18:49:42 UTC) #3
nasko
D'oh, sorry about that. LGTM
6 years, 1 month ago (2014-11-04 19:01:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/700923003/1
6 years, 1 month ago (2014-11-04 21:33:16 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-04 22:44:41 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 22:45:25 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b789ef8f4f2b7ff37137f650525c5c6044b7bf7
Cr-Commit-Position: refs/heads/master@{#302692}

Powered by Google App Engine
This is Rietveld 408576698