Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 700913003: Resolve race condition in CompilationCacheTable::Put (Closed)

Created:
6 years, 1 month ago by Jarin
Modified:
6 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Resolve race condition with GC in CompilationCacheTable::Put. The trouble is that the AsHandle method can allocate and thus invoke GC, which could empty the table while we are updating it. BUG=chromium:430880 LOG=N R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25229

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -12 lines) Patch
M src/objects.cc View 2 chunks +18 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jarin
Could you take a look, please? I could upload the clusterfuzz repro case, but it ...
6 years, 1 month ago (2014-11-06 13:56:55 UTC) #2
Toon Verwaest
lgtm
6 years, 1 month ago (2014-11-06 16:00:40 UTC) #3
Jarin
6 years, 1 month ago (2014-11-10 05:50:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 25229 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698