Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 700843006: Don't require getPropertyCSSValue in svg tests (Closed)

Created:
6 years, 1 month ago by Timothy Loh
Modified:
6 years, 1 month ago
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Don't require getPropertyCSSValue in svg tests As getPropertyCSSValue is no longer web-exposed we shouldn't require it in tests so we can delete the interface. BUG=428595 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185080

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -818 lines) Patch
M LayoutTests/svg/animations/animate-color-rgba-calcMode-discrete-expected.txt View 1 chunk +24 lines, -24 lines 0 comments Download
M LayoutTests/svg/animations/animate-css-xml-attributeType-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/animations/change-css-property-while-animating-fill-freeze-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/svg/animations/change-css-property-while-animating-fill-remove-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/svg/animations/script-tests/animate-color-rgba-calcMode-discrete.js View 1 chunk +5 lines, -12 lines 0 comments Download
M LayoutTests/svg/animations/script-tests/animate-css-xml-attributeType.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/animations/script-tests/change-css-property-while-animating-fill-freeze.js View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/svg/animations/script-tests/change-css-property-while-animating-fill-remove.js View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/svg/css/getComputedStyle-basic.xhtml View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/svg/css/getComputedStyle-basic-expected.txt View 1 chunk +0 lines, -466 lines 0 comments Download
M LayoutTests/svg/css/glyph-orientation-rounding-test.xhtml View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/css/glyph-orientation-rounding-test-expected.txt View 2 chunks +92 lines, -92 lines 0 comments Download
M LayoutTests/svg/css/rect-system-color.xhtml View 1 chunk +5 lines, -25 lines 0 comments Download
M LayoutTests/svg/css/rect-system-color-expected.txt View 1 chunk +56 lines, -168 lines 0 comments Download
M LayoutTests/svg/transforms/transform-origin-presentation-attribute.xhtml View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Timothy Loh
6 years, 1 month ago (2014-11-10 18:52:04 UTC) #2
alancutter (OOO until 2018)
lgtm
6 years, 1 month ago (2014-11-11 00:23:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/700843006/1
6 years, 1 month ago (2014-11-11 00:24:36 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 00:28:36 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 185080

Powered by Google App Engine
This is Rietveld 408576698