Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 700843004: cc: Fix WeakPtrFactory::GetWeakPtr() race when using multiple raster worker threads. (Closed)

Created:
6 years, 1 month ago by reveman
Modified:
6 years, 1 month ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Fix WeakPtrFactory::GetWeakPtr() race when using multiple raster worker threads. This prevents multiple threads from being able to call GetWeakPtr() at the same time by making sure the lock is acquired when this is called. R=vmpstr@chromium.org BUG= Committed: https://crrev.com/d130dcddb4bced6c4058d8d2fd6560b41fc5103a Cr-Commit-Position: refs/heads/master@{#302717}

Patch Set 1 #

Patch Set 2 : some cleanup #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -42 lines) Patch
M cc/resources/one_copy_raster_worker_pool.cc View 1 2 1 chunk +41 lines, -42 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
reveman
6 years, 1 month ago (2014-11-04 21:45:37 UTC) #1
vmpstr
lgtm
6 years, 1 month ago (2014-11-04 21:52:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/700843004/20001
6 years, 1 month ago (2014-11-04 22:44:36 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/22135) linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/8431) linux_chromium_compile_dbg_32 ...
6 years, 1 month ago (2014-11-04 22:50:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/700843004/40001
6 years, 1 month ago (2014-11-04 23:10:15 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-05 00:24:05 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 00:24:46 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d130dcddb4bced6c4058d8d2fd6560b41fc5103a
Cr-Commit-Position: refs/heads/master@{#302717}

Powered by Google App Engine
This is Rietveld 408576698