Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 700833002: Refactoring DevTools bridge tests: moving interface adapters to SignalingReceiverProxy. (Closed)

Created:
6 years, 1 month ago by SeRya
Modified:
6 years, 1 month ago
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@refactoring-1
Project:
chromium
Visibility:
Public.

Description

Refactoring DevTools bridge tests: moving interface adapters to SignalingReceiverProxy. Benefits of this refactoring are: 1. Removed a redundant adapter. 2. Removed an unnecessary interface conversion (A->B->A). 3. Removed from ClientSessionTestingHost references to unrelated class LocalSessionBridge. 4. Reduced number of public classes. BUG=383418 Committed: https://crrev.com/3508300bbf47fed5db4f0bcd8f11320c8439ba3b Cr-Commit-Position: refs/heads/master@{#302615}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
SeRya
PTAL
6 years, 1 month ago (2014-11-04 11:35:19 UTC) #2
mnaganov (inactive)
lgtm
6 years, 1 month ago (2014-11-04 15:44:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/700833002/1
6 years, 1 month ago (2014-11-04 15:47:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-04 16:34:12 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 16:34:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3508300bbf47fed5db4f0bcd8f11320c8439ba3b
Cr-Commit-Position: refs/heads/master@{#302615}

Powered by Google App Engine
This is Rietveld 408576698