bindings: Window must be LocalDOMWindow by definition.

bindings: Window must be LocalDOMWindow by definition.

Window.idl declares that Window is ImplementedAs=LocalDOMWindow.
It also declares self/window/frames/opener/parent/top attributes
return Window, so LocalDOMWindow::self/window/frames/opener/parent/
top member functions must return LocalDOMWindow, not DOMWindow.

dcheng@, you can change Window.idl to declare ImplementedAs=DOMWindow
instead of LocalDOMWindow, if necessary.  Otherwise, please keep the
consistency here.

BUG=425623
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184827

[Yuki, 2014-11-04 09:45:04]

yukishiino@chromium.org changed reviewers:
+ dcheng@chromium.org, haraken@chromium.org

[Yuki, 2014-11-04 09:45:04]

Could you guys review this CL?

This CL blocks http://crrev.com/684763004

[haraken, 2014-11-04 10:39:14]

This looks good but dcheng@ wants to confirm.

[dcheng, 2014-11-04 12:22:54]

On 2014/11/04 10:39:14, haraken wrote:
> This looks good but dcheng@ wants to confirm.

lgtm

Sorry, this was one of those "why does this compile" things I meant to
investigate further but lost track of in my patch sets. I still want to change
ImplementedAs to DOMWindow (https://codereview.chromium.org/683013002/), but
that patch is still in progress.

[Yuki, 2014-11-04 12:50:58]

The CQ bit was checked by yukishiino@chromium.org

[commit-bot: I haz the power, 2014-11-04 12:51:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/700803002/1

[commit-bot: I haz the power, 2014-11-04 13:55:42]

Committed patchset #1 (id:1) as 184827

[haraken, 2014-11-04 17:26:34]

LGTM