Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 7008009: Do not push a redundant value context in crankshaft. (Closed)

Created:
9 years, 7 months ago by Sven Panne
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Do not push a redundant value context in crankshaft. When visiting AND/OR nodes in a value context during Hydrogren graph generation, there is no need to push a new value context, the full code generator doesn't do it, either. While technically it doesn't hurt to do so, this change makes the context stacks for the full code generator and crankshaft more similar, which helps comparing the dynamic behaviour of these generators tremendously.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/hydrogen.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
9 years, 7 months ago (2011-05-25 07:19:45 UTC) #1
Sven Panne
9 years, 7 months ago (2011-05-26 07:18:46 UTC) #2
The right fix seems to be adding value contexts in the full code generator, not
removing context in crankshaft, so I'll close this issue.

Powered by Google App Engine
This is Rietveld 408576698