Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 700773002: Add a new command to summarize memory usage by function addresses in dmprof (Closed)

Created:
6 years, 1 month ago by wensheng
Modified:
6 years, 1 month ago
CC:
chromium-reviews, dmikurube+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add a new command to summarize memory usage by function addresses in dmprof The output format is: vss1;rss1;addr1;symbol1 vss2;rss2;addr2;symbol2 ... The symbol is related to the addr. If the binary file has symbols, it just same as before:function@sourcefile. Otherwise it will show the pathname the addr belongs to (mainly it's the library). This new command could be helpful for lcation leaks. R=kouhei@chromium.org BUG=427393 Committed: https://crrev.com/09714684ace60105a81c539516b945fe4d0b3d65 Cr-Commit-Position: refs/heads/master@{#302745}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -0 lines) Patch
M tools/deep_memory_profiler/dmprof.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/deep_memory_profiler/subcommands/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
A tools/deep_memory_profiler/subcommands/addr.py View 1 chunk +88 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
wensheng
6 years, 1 month ago (2014-11-04 08:50:32 UTC) #1
kouhei (in TOK)
6 years, 1 month ago (2014-11-04 17:50:18 UTC) #3
kouhei (in TOK)
lgtm
6 years, 1 month ago (2014-11-04 17:50:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/700773002/1
6 years, 1 month ago (2014-11-05 01:27:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-05 02:14:28 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 02:15:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09714684ace60105a81c539516b945fe4d0b3d65
Cr-Commit-Position: refs/heads/master@{#302745}

Powered by Google App Engine
This is Rietveld 408576698