Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/config/compiler/BUILD.gn

Issue 700763002: More Windows build fixes, some tidying in mojo_main (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: .gitignore Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | mojo/shell/BUILD.gn » ('j') | mojo/shell/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 44dfe7da131595dc25d7e7dd8a55e79ce0cced76..deb7c9f97b237bc30bc86a1d54ef55995f0342c1 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -528,6 +528,7 @@ config("chromium_code") {
if (is_win) {
cflags = [
"/W4", # Warning level 4.
+ "/wd4267", # TODO(jschuh): crbug.com/167187 size_t to int truncations.
]
} else {
cflags = [
@@ -558,6 +559,7 @@ config("no_chromium_code") {
cflags += [
"/W3", # Warning level 3.
"/wd4800", # Disable warning when forcing value to bool.
+ "/wd4267", # TODO(jschuh): crbug.com/167187 size_t to int truncations.
]
defines += [
"_CRT_NONSTDC_NO_WARNINGS",
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | mojo/shell/BUILD.gn » ('j') | mojo/shell/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698