Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 700763002: More Windows build fixes, some tidying in mojo_main (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: .gitignore Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 if (cpu_arch == "arm") { 6 if (cpu_arch == "arm") {
7 import("//build/config/arm.gni") 7 import("//build/config/arm.gni")
8 } 8 }
9 if (is_posix) { 9 if (is_posix) {
10 import("//build/config/gcc/gcc_version.gni") 10 import("//build/config/gcc/gcc_version.gni")
(...skipping 510 matching lines...) Expand 10 before | Expand all | Expand 10 after
521 521
522 # chromium_code --------------------------------------------------------------- 522 # chromium_code ---------------------------------------------------------------
523 # 523 #
524 # Toggles between higher and lower warnings for code that is (or isn't) 524 # Toggles between higher and lower warnings for code that is (or isn't)
525 # part of Chromium. 525 # part of Chromium.
526 526
527 config("chromium_code") { 527 config("chromium_code") {
528 if (is_win) { 528 if (is_win) {
529 cflags = [ 529 cflags = [
530 "/W4", # Warning level 4. 530 "/W4", # Warning level 4.
531 "/wd4267", # TODO(jschuh): crbug.com/167187 size_t to int truncations.
531 ] 532 ]
532 } else { 533 } else {
533 cflags = [ 534 cflags = [
534 "-Wall", 535 "-Wall",
535 "-Wextra", 536 "-Wextra",
536 537
537 # GCC turns on -Wsign-compare for C++ under -Wall, but clang doesn't, 538 # GCC turns on -Wsign-compare for C++ under -Wall, but clang doesn't,
538 # so we specify it explicitly. 539 # so we specify it explicitly.
539 # TODO(fischman): remove this if http://llvm.org/PR10448 obsoletes it. 540 # TODO(fischman): remove this if http://llvm.org/PR10448 obsoletes it.
540 # http://code.google.com/p/chromium/issues/detail?id=90453 541 # http://code.google.com/p/chromium/issues/detail?id=90453
(...skipping 10 matching lines...) Expand all
551 } 552 }
552 config("no_chromium_code") { 553 config("no_chromium_code") {
553 cflags = [] 554 cflags = []
554 cflags_cc = [] 555 cflags_cc = []
555 defines = [] 556 defines = []
556 557
557 if (is_win) { 558 if (is_win) {
558 cflags += [ 559 cflags += [
559 "/W3", # Warning level 3. 560 "/W3", # Warning level 3.
560 "/wd4800", # Disable warning when forcing value to bool. 561 "/wd4800", # Disable warning when forcing value to bool.
562 "/wd4267", # TODO(jschuh): crbug.com/167187 size_t to int truncations.
561 ] 563 ]
562 defines += [ 564 defines += [
563 "_CRT_NONSTDC_NO_WARNINGS", 565 "_CRT_NONSTDC_NO_WARNINGS",
564 "_CRT_NONSTDC_NO_DEPRECATE", 566 "_CRT_NONSTDC_NO_DEPRECATE",
565 ] 567 ]
566 } 568 }
567 569
568 if (is_linux) { 570 if (is_linux) {
569 # Don't warn about ignoring the return value from e.g. close(). This is 571 # Don't warn about ignoring the return value from e.g. close(). This is
570 # off by default in some gccs but on by default in others. BSD systems do 572 # off by default in some gccs but on by default in others. BSD systems do
(...skipping 384 matching lines...) Expand 10 before | Expand all | Expand 10 after
955 cflags += [ "-gsplit-dwarf" ] 957 cflags += [ "-gsplit-dwarf" ]
956 } 958 }
957 } 959 }
958 } 960 }
959 961
960 config("no_symbols") { 962 config("no_symbols") {
961 if (!is_win) { 963 if (!is_win) {
962 cflags = [ "-g0" ] 964 cflags = [ "-g0" ]
963 } 965 }
964 } 966 }
OLDNEW
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | mojo/shell/BUILD.gn » ('j') | mojo/shell/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698