Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 700753003: [turbofan] add some registerallocator unittests (Closed)

Created:
6 years, 1 month ago by dcarney
Modified:
6 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] add some registerallocator unittests BUG=

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : rebase #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Patch Set 12 : #

Patch Set 13 : #

Total comments: 1

Patch Set 14 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+389 lines, -164 lines) Patch
M test/unittests/compiler/register-allocator-unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 13 chunks +389 lines, -164 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Benedikt Meurer
https://codereview.chromium.org/700753003/diff/240001/test/unittests/compiler/register-allocator-unittest.cc File test/unittests/compiler/register-allocator-unittest.cc (right): https://codereview.chromium.org/700753003/diff/240001/test/unittests/compiler/register-allocator-unittest.cc#newcode362 test/unittests/compiler/register-allocator-unittest.cc:362: auto* unallocated = new (zone()) UnallocatedOperand(policy); auto* looks weird, ...
6 years, 1 month ago (2014-11-13 09:22:05 UTC) #2
dcarney
On 2014/11/13 09:22:05, Benedikt Meurer wrote: > https://codereview.chromium.org/700753003/diff/240001/test/unittests/compiler/register-allocator-unittest.cc > File test/unittests/compiler/register-allocator-unittest.cc (right): > > https://codereview.chromium.org/700753003/diff/240001/test/unittests/compiler/register-allocator-unittest.cc#newcode362 ...
6 years, 1 month ago (2014-11-13 09:24:51 UTC) #3
Benedikt Meurer
6 years, 1 month ago (2014-11-13 09:28:59 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698