IDL: Support union type arrays and sequences for method arguments

IDL: Support union type arrays and sequences for method arguments

toImplArray() template can convert arrays (or sequences) of T to
Vector<T> when T has NativeValueTraits. Generate them for union type
containers so that we can use (A or B)[] (or sequence<(A or B)>)
in method arguments.

Note that we can't use union type arrays and sequences for
return values yet. Follow-up CLs will support return values.

BUG=240176
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185096

[bashi, 2014-11-07 10:09:58]

bashi@chromium.org changed reviewers:
+ haraken@chromium.org, jl@opera.com

[bashi, 2014-11-07 10:09:59]

Haraken-san, Jens, PTAL?

(Sorry for asking reviews many times...)

[Jens Widell, 2014-11-07 11:18:13]

https://codereview.chromium.org/700733003/diff/1/Source/bindings/tests/result...
File Source/bindings/tests/results/core/V8UnionTypesCore.h (right):

https://codereview.chromium.org/700733003/diff/1/Source/bindings/tests/result...
Source/bindings/tests/results/core/V8UnionTypesCore.h:36: static
BooleanOrStringOrUnrestrictedDouble nativeValue(const v8::Handle<v8::Value>&
value, v8::Isolate* isolate, ExceptionState& exceptionState)
Wouldn't it work to "outline" these method implementations (put them in the .cpp
file)?

It should be enough to show the compiler that there's a template specialization
of the struct; it doesn't need have the definitions of the member methods (since
they're not templates.)

[haraken, 2014-11-07 18:14:44]

https://codereview.chromium.org/700733003/diff/1/Source/bindings/tests/result...
File Source/bindings/tests/results/core/V8UnionTypesCore.h (right):

https://codereview.chromium.org/700733003/diff/1/Source/bindings/tests/result...
Source/bindings/tests/results/core/V8UnionTypesCore.h:36: static
BooleanOrStringOrUnrestrictedDouble nativeValue(const v8::Handle<v8::Value>&
value, v8::Isolate* isolate, ExceptionState& exceptionState)
On 2014/11/07 11:18:13, Jens Widell wrote:
> Wouldn't it work to "outline" these method implementations (put them in the
.cpp
> file)?
> 
> It should be enough to show the compiler that there's a template
specialization
> of the struct; it doesn't need have the definitions of the member methods
(since
> they're not templates.)

If this works, can we generate the NativeValueTraits to UnionTypeCore.h ?

[bashi, 2014-11-08 07:03:30]

On 2014/11/07 18:14:44, haraken wrote:
>
https://codereview.chromium.org/700733003/diff/1/Source/bindings/tests/result...
> File Source/bindings/tests/results/core/V8UnionTypesCore.h (right):
> 
>
https://codereview.chromium.org/700733003/diff/1/Source/bindings/tests/result...
> Source/bindings/tests/results/core/V8UnionTypesCore.h:36: static
> BooleanOrStringOrUnrestrictedDouble nativeValue(const v8::Handle<v8::Value>&
> value, v8::Isolate* isolate, ExceptionState& exceptionState)
> On 2014/11/07 11:18:13, Jens Widell wrote:
> > Wouldn't it work to "outline" these method implementations (put them in the
> .cpp
> > file)?
> > 
> > It should be enough to show the compiler that there's a template
> specialization
> > of the struct; it doesn't need have the definitions of the member methods
> (since
> > they're not templates.)
> 
> If this works, can we generate the NativeValueTraits to UnionTypeCore.h ?

Thank you for suggestion. I'll try it next week.

[bashi, 2014-11-11 01:34:46]

Revised the CL(the CL become simple:). PTAL?

https://codereview.chromium.org/700733003/diff/20001/Source/bindings/tests/re...
File Source/bindings/tests/results/core/V8TestInterface.cpp (right):

https://codereview.chromium.org/700733003/diff/20001/Source/bindings/tests/re...
Source/bindings/tests/results/core/V8TestInterface.cpp:1164: DOMWindow* window;
This was fixed by another CL. Will rebase.

[haraken, 2014-11-11 02:14:29]

LGTM

[bashi, 2014-11-11 03:21:21]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2014-11-11 03:21:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/700733003/60001

[commit-bot: I haz the power, 2014-11-11 03:49:36]

Committed patchset #4 (id:60001) as 185096