Refactoring spellcheck-disable-enable.html to use async path for spellcheck

Refactoring spellcheck-disable-enable.html to use async path for spellcheck

Use asynchronous spellchecking in spellcheck-disable-enable.html.

In addition, use more descriptive variable names and simplify the test.
Automatically fill in the misspellings to the editable fields so
non DumpRenderTree users don't have to do that.

BUG=295722
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162125

[tony, 2013-11-13 17:30:33]

LGTM

https://codereview.chromium.org/70073005/diff/1/LayoutTests/editing/spelling/...
File LayoutTests/editing/spelling/spellcheck-disable-enable.html (right):

https://codereview.chromium.org/70073005/diff/1/LayoutTests/editing/spelling/...
LayoutTests/editing/spelling/spellcheck-disable-enable.html:22: return
internals.markerCountForNode(element.firstChild, "spelling") ? true : false;
Nit: return !!internals.markerCountForNode(element.firstChild, "spelling");

[groby-ooo-7-16, 2013-11-13 18:16:19]

lgtm

[grzegorz, 2013-11-14 08:44:22]

https://codereview.chromium.org/70073005/diff/1/LayoutTests/editing/spelling/...
File LayoutTests/editing/spelling/spellcheck-disable-enable.html (right):

https://codereview.chromium.org/70073005/diff/1/LayoutTests/editing/spelling/...
LayoutTests/editing/spelling/spellcheck-disable-enable.html:22: return
internals.markerCountForNode(element.firstChild, "spelling") ? true : false;
On 2013/11/13 17:30:34, tony wrote:
> Nit: return !!internals.markerCountForNode(element.firstChild, "spelling");

Thanks. Done.

[commit-bot: I haz the power, 2013-11-14 08:45:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/g.czajkowski@samsung.com/70073005/70001

[commit-bot: I haz the power, 2013-11-14 11:13:47]

Retried try job too often on win_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[grzegorz, 2013-11-14 12:03:28]

It seems that the newly changed test fails on some bots:

-PASS hasSpellingMarkerOnSetting(editableDiv, true) became true
+FAIL hasSpellingMarkerOnSetting(editableDiv, true) failed to change to true in
0.5 seconds.

I'll take care of this.

[grzegorz, 2013-11-15 11:29:37]

On 2013/11/14 12:03:28, grzegorz wrote:
> It seems that the newly changed test fails on some bots:
> 
> -PASS hasSpellingMarkerOnSetting(editableDiv, true) became true
> +FAIL hasSpellingMarkerOnSetting(editableDiv, true) failed to change to true
in
> 0.5 seconds.
> 
> I'll take care of this.

For misspellings that are already inserted into editable (for example, when they
are created) needs change of a caret to perform spellchecking. Focus on them
(what I proposed in patch#2) is not enough especially for the second element.
This happens in asynchronous path only.

Inserting misspellings while typing (via execComnnad) guarantees that we can
verify markers at any time (proposed in patch #3). Changes are non significant
but I assume that I need another LGTM.

[tony, 2013-11-15 17:00:38]

LGTM

[commit-bot: I haz the power, 2013-11-15 17:01:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/g.czajkowski@samsung.com/70073005/250001

[commit-bot: I haz the power, 2013-11-15 18:26:32]

Change committed as 162125