Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4732)

Unified Diff: chrome/browser/enumerate_modules_model_win.cc

Issue 700713002: Fix unreachable code bug caused by anding with zero, per finnur@. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/enumerate_modules_model_win.cc
diff --git a/chrome/browser/enumerate_modules_model_win.cc b/chrome/browser/enumerate_modules_model_win.cc
index 563f46453e732c69ef0ecb1d072d9eaddbeb3ce5..29524a7a06bfe145313689a36dfcf90023ab58c9 100644
--- a/chrome/browser/enumerate_modules_model_win.cc
+++ b/chrome/browser/enumerate_modules_model_win.cc
@@ -895,7 +895,7 @@ base::ListValue* EnumerateModulesModel::GetModuleList() const {
IDS_CONFLICTS_CHECK_POSSIBLE_ACTION_SEPARATOR) +
base::ASCIIToWide(" ");
- if (module->recommended_action & ModuleEnumerator::NONE) {
+ if (module->recommended_action == ModuleEnumerator::NONE) {
Finnur 2014/11/04 17:10:15 No, you were right. Now that I'm a little fresher
actions = l10n_util::GetStringUTF16(
IDS_CONFLICTS_CHECK_INVESTIGATING);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698