Fix unreachable code bug caused by anding with zero, per finnur@.

Fix unreachable code bug caused by anding with zero, per finnur@.

VC++'s /analyze pointed out that an incorrect operator was being used.
The warning was:

src\chrome\browser\enumerate_modules_model_win.cc(898) : warning C6313:
Incorrect operator:  zero-valued flag cannot be tested with bitwise-and.
Use an equality test to check for zero-valued flags.

This bug dates back to the original code in November 2010. Fixed to 'and' with the INVESTIGATING value, as intended, after discussion with finnur@.

BUG=427616
Committed: https://crrev.com/4e7e6b35fd63a90f5f93227200249ebfa61dd5a1
Cr-Commit-Position: refs/heads/master@{#302715}

[brucedawson, 2014-11-04 01:16:33]

brucedawson@chromium.org changed reviewers:
+ finnur@chromium.org

[brucedawson, 2014-11-04 01:50:13]

On 2014/11/04 01:17:18, brucedawson wrote:

The two obvious ways to fix this bug are to change the & operator to == (to
allow detection of zero) or to change the value being tested from
ModuleEnumerator::NONE to ModuleEnumerator::INVESTIGATING (thus following the
pattern of the subsequent if blocks. I just want to confirm that the == fix is
actually the correct one.

[Finnur, 2014-11-04 17:10:15]

https://codereview.chromium.org/700713002/diff/1/chrome/browser/enumerate_mod...
File chrome/browser/enumerate_modules_model_win.cc (right):

https://codereview.chromium.org/700713002/diff/1/chrome/browser/enumerate_mod...
chrome/browser/enumerate_modules_model_win.cc:898: if
(module->recommended_action == ModuleEnumerator::NONE) {
No, you were right. Now that I'm a little fresher in the morning and not as
jet-lagged I realize I gave you the wrong advice. Revert this change and swap
NONE for INVESTIGATING.

https://codereview.chromium.org/700713002/diff/1/chrome/browser/enumerate_mod...
chrome/browser/enumerate_modules_model_win.cc:919: }
I still think, for bonus points, everything from line 902 to 919 should be
encapsulated in an else-if off of the if statement on line 898 because
INVESTIGATING is what we should show before we figure out what to advice, either
UNINSTALL, UPDATE and/or DISABLE. 

You won't be changing any codepaths by doing so because if you grep for
INVESTIGATING within this file you'll see that it is never (and was never meant
to be) used in conjunction with the other three, only with SEE_LINK, which is
handled separately.

[brucedawson, 2014-11-04 18:24:01]

Fixed as discussed.

[Finnur, 2014-11-04 18:39:15]

LGTM

[brucedawson, 2014-11-04 23:26:53]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2014-11-04 23:28:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/700713002/20001

[commit-bot: I haz the power, 2014-11-05 00:17:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-05 00:17:45]

Patchset 2 (id:??) landed as
https://crrev.com/4e7e6b35fd63a90f5f93227200249ebfa61dd5a1
Cr-Commit-Position: refs/heads/master@{#302715}