Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 700703003: Revert of Switch telemetry over to use typ to run the unit tests. (Closed)

Created:
6 years, 1 month ago by tzik
Modified:
6 years, 1 month ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@rev_typ_v086
Project:
chromium
Visibility:
Public.

Description

Revert of Switch telemetry over to use typ to run the unit tests. (patchset #9 id:170001 of https://codereview.chromium.org/659293003/) Reason for revert: This CL causes telemetry_perf_unittests failure: http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests&number=15802 http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.6%20Tests%20%28dbg%29%281%29&number=54625 Its stack trace was: Traceback (most recent call last): <module> at tools/telemetry/telemetry/unittest/run_tests.py:179 RunTestsCommand.main() main at tools/telemetry/telemetry/unittest/run_tests.py:85 return obj.Run(options) Run at tools/telemetry/telemetry/unittest/run_tests.py:126 ret, _, _ = runner.run() run at third_party/typ/typ/runner.py:187 upload_ret = self._upload(full_results) _upload at third_party/typ/typ/runner.py:599 full_results) make_upload_request at third_party/typ/typ/json_results.py:113 content_type, data = _encode_multipart_form_data(attrs, full_results) _encode_multipart_form_data at third_party/typ/typ/json_results.py:183 body = CRLF.join(lines) TypeError: sequence item 3: expected string, NoneType found Original issue's description: > Switch telemetry over to use typ to run the unit tests. > > Using typ allows us to run the tests in parallel and share > the logic for parsing the results and uploading them to the > flakiness dashboard with other python test steps. > > R=dtu@chromium.org, tonyg@chromium.org, nduca@chromium.org > BUG=402172, 388256 > > Committed: https://crrev.com/3e7c2a6ee80e05fc6b8090bee850c40b8a2a3810 > Cr-Commit-Position: refs/heads/master@{#302570} TBR=dtu@chromium.org,tonyg@chromium.org,nduca@chromium.org,achuith@chromium.org,dpranke@chromium.org NOTREECHECKS=true NOTRY=true BUG=402172, 388256 Committed: https://crrev.com/6b7b079c44bf080dc3773a50f2541b032f495ce9 Cr-Commit-Position: refs/heads/master@{#302575}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+524 lines, -316 lines) Patch
M tools/perf/run_tests View 1 chunk +10 lines, -15 lines 0 comments Download
M tools/telemetry/PRESUBMIT.py View 1 chunk +1 line, -3 lines 0 comments Download
M tools/telemetry/bootstrap_deps View 1 chunk +30 lines, -17 lines 0 comments Download
M tools/telemetry/run_tests View 1 chunk +8 lines, -14 lines 0 comments Download
M tools/telemetry/telemetry/decorators.py View 3 chunks +16 lines, -64 lines 0 comments Download
M tools/telemetry/telemetry/unittest/browser_test_case.py View 1 chunk +14 lines, -35 lines 0 comments Download
A tools/telemetry/telemetry/unittest/json_results.py View 1 chunk +247 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/unittest/run_chromeos_tests.py View 2 chunks +26 lines, -18 lines 0 comments Download
M tools/telemetry/telemetry/unittest/run_tests.py View 3 chunks +154 lines, -125 lines 0 comments Download
M tools/telemetry/telemetry/unittest/run_tests_unittest.py View 2 chunks +17 lines, -17 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py View 4 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tzik
Created Revert of Switch telemetry over to use typ to run the unit tests.
6 years, 1 month ago (2014-11-04 05:03:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/700703003/1
6 years, 1 month ago (2014-11-04 05:04:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-04 05:05:23 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6b7b079c44bf080dc3773a50f2541b032f495ce9 Cr-Commit-Position: refs/heads/master@{#302575}
6 years, 1 month ago (2014-11-04 05:05:52 UTC) #4
Dirk Pranke
6 years, 1 month ago (2014-11-04 17:02:21 UTC) #5
Message was sent while issue was closed.
On 2014/11/04 05:05:52, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/6b7b079c44bf080dc3773a50f2541b032f495ce9
> Cr-Commit-Position: refs/heads/master@{#302575}

lgtm, thanks for reverting.

Powered by Google App Engine
This is Rietveld 408576698