sky/engine/core/css/resolver/StyleAdjuster.cpp - Issue 700703002: Remove more float machinery.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/css/resolver/StyleAdjuster.cpp

Issue 700703002: Remove more float machinery. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/css/resolver/StyleAdjuster.cpp

diff --git a/sky/engine/core/css/resolver/StyleAdjuster.cpp b/sky/engine/core/css/resolver/StyleAdjuster.cpp

index ee6b0050a07aee214cd84169d2cff656c9b6097a..74860621785d519f98aeb69b439cb17faf2bcc8c 100644

--- a/sky/engine/core/css/resolver/StyleAdjuster.cpp

+++ b/sky/engine/core/css/resolver/StyleAdjuster.cpp

@@ -108,9 +108,6 @@ void StyleAdjuster::adjustRenderStyle(RenderStyle* style, RenderStyle* parentSty

{

ASSERT(parentStyle);

- // FIXME(sky): Remove floats.

- style->setFloating(NoFloat);

if (style->display() != NONE) {

// Absolute/fixed positioned elements, floating elements and the document element need block-like outside display.

if (style->hasOutOfFlowPosition() || element.document().documentElement() == element)