Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 700683002: Manually load CONDITION_VARIABLE methods on Windows, checking for failure (XP). (Closed)

Created:
6 years, 1 month ago by mtklein_C
Modified:
6 years, 1 month ago
CC:
reviews_skia.org, reed1
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Manually load CONDITION_VARIABLE methods on Windows, checking for failure (XP). Tested by running DM on XP. Before this patch, it fails at startup (even just out/Debug/dm --help). Now it asserts for other reasons later on in user code, which is just fine by me. The net effect is that SkTaskGroups will always be synchronous on XP. That's not ideal, but a step up from crashing. CQ_EXTRA_TRYBOTS=client.skia:Test-Win7-ShuttleA-HD2000-x86-Release-Trybot,Test-Win7-ShuttleA-HD2000-x86_64-Release-Trybot BUG=skia: Committed: https://skia.googlesource.com/skia/+/db8d0e5bb018594d0ced3bfa68484115d8cf76b8

Patch Set 1 #

Patch Set 2 : spelling #

Patch Set 3 : winapi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -16 lines) Patch
M src/core/SkTaskGroup.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkCondVar.h View 1 chunk +9 lines, -11 lines 0 comments Download
M src/utils/SkCondVar.cpp View 1 2 4 chunks +41 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/700683002/20001
6 years, 1 month ago (2014-11-03 21:59:14 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-03 21:59:15 UTC) #3
mtklein
6 years, 1 month ago (2014-11-03 22:01:27 UTC) #6
reed1
lgtm
6 years, 1 month ago (2014-11-03 22:03:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/700683002/40001
6 years, 1 month ago (2014-11-03 22:25:17 UTC) #10
commit-bot: I haz the power
Transient error: Invalid delimiter in "Test-Win7-ShuttleA-HD2000-x86-Release-Trybot,Test-Win7-ShuttleA-HD2000-x86_64-Release-Trybot": Correct syntax is "tryserver:bot1,bot2;tryserver2:bot3,bot4;".
6 years, 1 month ago (2014-11-03 22:25:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/700683002/40001
6 years, 1 month ago (2014-11-03 22:25:49 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 01:25:57 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as db8d0e5bb018594d0ced3bfa68484115d8cf76b8

Powered by Google App Engine
This is Rietveld 408576698