Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5800)

Unified Diff: chrome/browser/ui/views/toolbar/wrench_menu.h

Issue 700673003: Add metrics to all items in the 'wrench' menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add WrenchMenu.TimeToAction timings histogram Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/wrench_menu.h
diff --git a/chrome/browser/ui/views/toolbar/wrench_menu.h b/chrome/browser/ui/views/toolbar/wrench_menu.h
index 267f1deb9f4e4527e01984cc97f94573562aab6d..b115ea94fa4d2f5405c5950fdad3409b2e41b666 100644
--- a/chrome/browser/ui/views/toolbar/wrench_menu.h
+++ b/chrome/browser/ui/views/toolbar/wrench_menu.h
@@ -10,6 +10,8 @@
#include "base/memory/scoped_ptr.h"
#include "base/observer_list.h"
+#include "base/time/time.h"
+#include "base/timer/elapsed_timer.h"
#include "components/bookmarks/browser/base_bookmark_model_observer.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
@@ -184,6 +186,9 @@ class WrenchMenu : public views::MenuDelegate,
ObserverList<WrenchMenuObserver> observer_list_;
+ // Timer for menu open metrics.
Peter Kasting 2014/11/14 19:48:59 Nit: This comment adds nothing to the member name.
edwardjung 2014/11/17 15:58:24 Removed.
+ base::ElapsedTimer menu_opened_timer_;
+
DISALLOW_COPY_AND_ASSIGN(WrenchMenu);
};

Powered by Google App Engine
This is Rietveld 408576698