Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Side by Side Diff: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc

Issue 700673003: Add metrics to all items in the 'wrench' menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix merge conflicts Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h" 5 #include "chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/metrics/histogram.h" 8 #include "base/metrics/histogram.h"
9 #include "base/prefs/scoped_user_pref_update.h" 9 #include "base/prefs/scoped_user_pref_update.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 292 matching lines...) Expand 10 before | Expand all | Expand 10 after
303 if (service && delegate) { 303 if (service && delegate) {
304 int window_items_idx = CommandIdToWindowVectorIndex(command_id); 304 int window_items_idx = CommandIdToWindowVectorIndex(command_id);
305 DCHECK(window_items_idx >= 0 && 305 DCHECK(window_items_idx >= 0 &&
306 window_items_idx < static_cast<int>(local_window_items_.size())); 306 window_items_idx < static_cast<int>(local_window_items_.size()));
307 UMA_HISTOGRAM_ENUMERATION("WrenchMenu.RecentTabsSubMenu", RESTORE_WINDOW, 307 UMA_HISTOGRAM_ENUMERATION("WrenchMenu.RecentTabsSubMenu", RESTORE_WINDOW,
308 LIMIT_RECENT_TAB_ACTION); 308 LIMIT_RECENT_TAB_ACTION);
309 service->RestoreEntryById(delegate, local_window_items_[window_items_idx], 309 service->RestoreEntryById(delegate, local_window_items_[window_items_idx],
310 browser_->host_desktop_type(), disposition); 310 browser_->host_desktop_type(), disposition);
311 } 311 }
312 } 312 }
313 UMA_HISTOGRAM_TIMES("WrenchMenu.TimeToAction.RecentTab",
314 menu_opened_timer_.Elapsed());
315 UMA_HISTOGRAM_ENUMERATION("WrenchMenu.MenuAction", MENU_ACTION_RECENT_TAB,
316 LIMIT_MENU_ACTION);
313 } 317 }
314 318
315 int RecentTabsSubMenuModel::GetFirstRecentTabsCommandId() { 319 int RecentTabsSubMenuModel::GetFirstRecentTabsCommandId() {
316 return WindowVectorIndexToCommandId(0); 320 return WindowVectorIndexToCommandId(0);
317 } 321 }
318 322
319 const gfx::FontList* RecentTabsSubMenuModel::GetLabelFontListAt( 323 const gfx::FontList* RecentTabsSubMenuModel::GetLabelFontListAt(
320 int index) const { 324 int index) const {
321 int command_id = GetCommandIdAt(index); 325 int command_id = GetCommandIdAt(index);
322 if (command_id == kRecentlyClosedHeaderCommandId || 326 if (command_id == kRecentlyClosedHeaderCommandId ||
(...skipping 360 matching lines...) Expand 10 before | Expand all | Expand 10 after
683 687
684 ui::MenuModelDelegate* menu_model_delegate = GetMenuModelDelegate(); 688 ui::MenuModelDelegate* menu_model_delegate = GetMenuModelDelegate();
685 if (menu_model_delegate) 689 if (menu_model_delegate)
686 menu_model_delegate->OnMenuStructureChanged(); 690 menu_model_delegate->OnMenuStructureChanged();
687 } 691 }
688 692
689 void RecentTabsSubMenuModel::TabRestoreServiceDestroyed( 693 void RecentTabsSubMenuModel::TabRestoreServiceDestroyed(
690 TabRestoreService* service) { 694 TabRestoreService* service) {
691 TabRestoreServiceChanged(service); 695 TabRestoreServiceChanged(service);
692 } 696 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h ('k') | chrome/browser/ui/toolbar/wrench_menu_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698