Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1430)

Side by Side Diff: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc

Issue 700673003: Add metrics to all items in the 'wrench' menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add WrenchMenu.TimeToAction timings histogram Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h" 5 #include "chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/metrics/histogram.h" 8 #include "base/metrics/histogram.h"
9 #include "base/prefs/scoped_user_pref_update.h" 9 #include "base/prefs/scoped_user_pref_update.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 291 matching lines...) Expand 10 before | Expand all | Expand 10 after
302 if (service && delegate) { 302 if (service && delegate) {
303 int window_items_idx = CommandIdToWindowVectorIndex(command_id); 303 int window_items_idx = CommandIdToWindowVectorIndex(command_id);
304 DCHECK(window_items_idx >= 0 && 304 DCHECK(window_items_idx >= 0 &&
305 window_items_idx < static_cast<int>(local_window_items_.size())); 305 window_items_idx < static_cast<int>(local_window_items_.size()));
306 UMA_HISTOGRAM_ENUMERATION("WrenchMenu.RecentTabsSubMenu", RESTORE_WINDOW, 306 UMA_HISTOGRAM_ENUMERATION("WrenchMenu.RecentTabsSubMenu", RESTORE_WINDOW,
307 LIMIT_RECENT_TAB_ACTION); 307 LIMIT_RECENT_TAB_ACTION);
308 service->RestoreEntryById(delegate, local_window_items_[window_items_idx], 308 service->RestoreEntryById(delegate, local_window_items_[window_items_idx],
309 browser_->host_desktop_type(), disposition); 309 browser_->host_desktop_type(), disposition);
310 } 310 }
311 } 311 }
312 UMA_HISTOGRAM_TIMES("WrenchMenu.TimeToAction.RecentTab", timer.Elapsed());
313 UMA_HISTOGRAM_ENUMERATION("WrenchMenu.MenuAction", MENU_ACTION_RECENT_TAB,
314 LIMIT_MENU_ACTION);
312 } 315 }
313 316
314 int RecentTabsSubMenuModel::GetFirstRecentTabsCommandId() { 317 int RecentTabsSubMenuModel::GetFirstRecentTabsCommandId() {
315 return WindowVectorIndexToCommandId(0); 318 return WindowVectorIndexToCommandId(0);
316 } 319 }
317 320
318 const gfx::FontList* RecentTabsSubMenuModel::GetLabelFontListAt( 321 const gfx::FontList* RecentTabsSubMenuModel::GetLabelFontListAt(
319 int index) const { 322 int index) const {
320 int command_id = GetCommandIdAt(index); 323 int command_id = GetCommandIdAt(index);
321 if (command_id == kRecentlyClosedHeaderCommandId || 324 if (command_id == kRecentlyClosedHeaderCommandId ||
(...skipping 360 matching lines...) Expand 10 before | Expand all | Expand 10 after
682 685
683 ui::MenuModelDelegate* menu_model_delegate = GetMenuModelDelegate(); 686 ui::MenuModelDelegate* menu_model_delegate = GetMenuModelDelegate();
684 if (menu_model_delegate) 687 if (menu_model_delegate)
685 menu_model_delegate->OnMenuStructureChanged(); 688 menu_model_delegate->OnMenuStructureChanged();
686 } 689 }
687 690
688 void RecentTabsSubMenuModel::TabRestoreServiceDestroyed( 691 void RecentTabsSubMenuModel::TabRestoreServiceDestroyed(
689 TabRestoreService* service) { 692 TabRestoreService* service) {
690 TabRestoreServiceChanged(service); 693 TabRestoreServiceChanged(service);
691 } 694 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698