Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 700663004: [Streams] Add "useStreamOnResponse" on WebURLRequest. (Closed)

Created:
6 years, 1 month ago by yhirano
Modified:
6 years, 1 month ago
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@use-web-data-pipe
Project:
blink
Visibility:
Public.

Description

[Streams] Add "useStreamOnResponse" on WebURLRequest. In order to demonstrate the requestor wants to receive the body stream as a byte stream, this CL adds a flag in WebURLRequest and ResourceRequest. BUG=418879 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185351

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Total comments: 4

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M Source/platform/exported/WebURLRequest.cpp View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M Source/platform/network/ResourceRequest.h View 1 2 3 4 3 chunks +7 lines, -0 lines 0 comments Download
M Source/platform/network/ResourceRequest.cpp View 1 2 3 4 3 chunks +3 lines, -0 lines 0 comments Download
M public/platform/WebURLRequest.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
yhirano
6 years, 1 month ago (2014-11-11 01:57:09 UTC) #2
tyoshino (SeeGerritForStatus)
Description: staream -> stream
6 years, 1 month ago (2014-11-12 04:14:27 UTC) #3
yhirano
On 2014/11/12 04:14:27, tyoshino wrote: > Description: > > staream -> stream Thanks, done.
6 years, 1 month ago (2014-11-12 04:21:02 UTC) #4
tyoshino (SeeGerritForStatus)
lgtm https://codereview.chromium.org/700663004/diff/40001/Source/platform/exported/WebURLRequest.cpp File Source/platform/exported/WebURLRequest.cpp (right): https://codereview.chromium.org/700663004/diff/40001/Source/platform/exported/WebURLRequest.cpp#newcode321 Source/platform/exported/WebURLRequest.cpp:321: how about putting this next to downloadToFile as ...
6 years, 1 month ago (2014-11-12 04:22:03 UTC) #5
yhirano
https://codereview.chromium.org/700663004/diff/40001/Source/platform/exported/WebURLRequest.cpp File Source/platform/exported/WebURLRequest.cpp (right): https://codereview.chromium.org/700663004/diff/40001/Source/platform/exported/WebURLRequest.cpp#newcode321 Source/platform/exported/WebURLRequest.cpp:321: On 2014/11/12 04:22:03, tyoshino wrote: > how about putting ...
6 years, 1 month ago (2014-11-12 04:52:09 UTC) #6
yhirano
+mkwst for OWNER review.
6 years, 1 month ago (2014-11-13 08:32:00 UTC) #8
Mike West
LGTM.
6 years, 1 month ago (2014-11-13 08:39:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/700663004/80001
6 years, 1 month ago (2014-11-14 04:13:04 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 05:59:21 UTC) #12
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as 185351

Powered by Google App Engine
This is Rietveld 408576698