Issue 700603002: Specs: Add a URL field to the Module and Application objects. Note

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 700603002: Specs: Add a URL field to the Module and Application objects. Note (Closed)

Created:
6 years, 1 month ago by Hixie

Modified:
6 years, 1 month ago

Reviewers:

CC:
mojo-reviews_chromium.org, ojan, esprehn, abarth-chromium

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Specs: Add a URL field to the Module and Application objects. Note that this makes the constructor for Module now have three arguments. They're all non-optional which is why I didn't turn it into a dictionary, but maybe it's time to start thinking about that. And maybe URL should be optional. Committed: https://chromium.googlesource.com/external/mojo/+/baaf45922898e92b4b2856241dd6ac5ae98ab00f

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	sky/specs/apis.md	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Hixie

6 years, 1 month ago (2014-11-03 19:08:02 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
baaf45922898e92b4b2856241dd6ac5ae98ab00f.

Expand Messages | Collapse Messages