Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 700583005: Add HTTP/2 error code from latest draft. (Closed)

Created:
6 years, 1 month ago by Bence
Modified:
6 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add HTTP/2 error code from latest draft. Add HTTP_1_1_REQUIRED error code for RST_STREAM and GOAWAY frames that was introduced in draft-15. Also add INADEQUATE_SECURTY error code wherever it had been forgotten. This lands server change 79690279 by bnc in spdy_framer.cc and spdy_protocol.{h,cc}. BUG=431306 Committed: https://crrev.com/62acceb2fda95d23ae8081ac3d22e7b49e8ee099 Cr-Commit-Position: refs/heads/master@{#303993}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -6 lines) Patch
M net/spdy/spdy_framer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/spdy/spdy_protocol.h View 2 chunks +5 lines, -2 lines 0 comments Download
M net/spdy/spdy_protocol.cc View 6 chunks +15 lines, -2 lines 0 comments Download
M net/spdy/spdy_session.h View 3 chunks +4 lines, -2 lines 0 comments Download
M net/spdy/spdy_session.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Bence
6 years, 1 month ago (2014-11-11 03:52:49 UTC) #2
Ryan Hamilton
Were the shared-code changes landed internally too?
6 years, 1 month ago (2014-11-11 03:55:31 UTC) #3
Bence
On 2014/11/11 03:55:31, Ryan Hamilton wrote: > Were the shared-code changes landed internally too? PTAL. ...
6 years, 1 month ago (2014-11-13 02:08:03 UTC) #4
Ryan Hamilton
lgtm
6 years, 1 month ago (2014-11-13 04:12:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/700583005/1
6 years, 1 month ago (2014-11-13 04:54:13 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-13 05:41:50 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 05:42:28 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62acceb2fda95d23ae8081ac3d22e7b49e8ee099
Cr-Commit-Position: refs/heads/master@{#303993}

Powered by Google App Engine
This is Rietveld 408576698