Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2331)

Unified Diff: chrome/browser/chromeos/accessibility/accessibility_manager.cc

Issue 700573002: Update the keyboard before notifying observers that it has changed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/accessibility/accessibility_manager.cc
diff --git a/chrome/browser/chromeos/accessibility/accessibility_manager.cc b/chrome/browser/chromeos/accessibility/accessibility_manager.cc
index c7a3d65763626521d5102b8f09b09e8d9081644e..a795d09f5d46b20558fd2f57ce0a0d0e109bfed4 100644
--- a/chrome/browser/chromeos/accessibility/accessibility_manager.cc
+++ b/chrome/browser/chromeos/accessibility/accessibility_manager.cc
@@ -802,13 +802,6 @@ void AccessibilityManager::UpdateVirtualKeyboardFromPref() {
return;
virtual_keyboard_enabled_ = enabled;
- AccessibilityStatusEventDetails details(
- ACCESSIBILITY_TOGGLE_VIRTUAL_KEYBOARD,
- enabled,
- ui::A11Y_NOTIFICATION_NONE);
-
- NotifyAccessibilityStatusChanged(details);
-
#if defined(USE_ASH) && !defined(USE_ATHENA)
keyboard::SetAccessibilityKeyboardEnabled(enabled);
// Note that there are two versions of the on-screen keyboard. A full layout
@@ -823,6 +816,12 @@ void AccessibilityManager::UpdateVirtualKeyboardFromPref() {
else
ash::Shell::GetInstance()->DeactivateKeyboard();
#endif
+
+ AccessibilityStatusEventDetails details(
+ ACCESSIBILITY_TOGGLE_VIRTUAL_KEYBOARD,
+ enabled,
+ ui::A11Y_NOTIFICATION_NONE);
+ NotifyAccessibilityStatusChanged(details);
}
bool AccessibilityManager::IsBrailleDisplayConnected() const {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698