Implementing directional text selection handles

ui/views/controls/textfield/textfield_unittest.cc

Index: ui/views/controls/textfield/textfield_unittest.cc
diff --git a/ui/views/controls/textfield/textfield_unittest.cc b/ui/views/controls/textfield/textfield_unittest.cc
index 28f75441c969bf1a6d2d7a4bdd173475941ff935..4947c3fce3b52a88a1b4063837aa8ef31281df1b 100644
--- a/ui/views/controls/textfield/textfield_unittest.cc
+++ b/ui/views/controls/textfield/textfield_unittest.cc
@@ -31,6 +31,7 @@
 #include "ui/views/test/test_views_delegate.h"
 #include "ui/views/test/views_test_base.h"
 #include "ui/views/widget/widget.h"
+#include "ui/wm/core/default_screen_position_client.h"
 #include "url/gurl.h"
 
 #if defined(OS_WIN)
@@ -210,6 +211,9 @@ class TextfieldTest : public ViewsTestBase, public TextfieldController {
     textfield_->SetBoundsRect(params.bounds);
     textfield_->set_id(1);
     test_api_.reset(new TextfieldTestApi(textfield_));
+    aura::client::SetScreenPositionClient(
+        widget_->GetNativeView()->GetRootWindow(),
+        &screen_position_client_);

[mohsen, 2014/11/10 22:25:59]

Can't this be moved to SetUp(), too?

[mfomitchev, 2014/11/10 23:07:29]

I think the widget's window is also the root window in this case, and the widget
is not created until this method is called, so we don't have anything to install
the client on in SetUp().

[mohsen, 2014/11/11 01:24:39]

I don't think so. You can use GetContext() in SetUp() to access root window
(after calling base SetUp()).

[mfomitchev, 2014/11/12 18:32:49]

Great, good to know, thanks!

 
     for (int i = 1; i < count; i++) {
       Textfield* textfield = new Textfield();
@@ -375,6 +379,7 @@ class TextfieldTest : public ViewsTestBase, public TextfieldController {
 
  private:
   ui::ClipboardType copied_to_clipboard_;
+  wm::DefaultScreenPositionClient screen_position_client_;
 
   DISALLOW_COPY_AND_ASSIGN(TextfieldTest);
 };