ui/views/controls/textfield/textfield.h - Issue 700563002: Implementing directional text selection handles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/textfield/textfield.h

Issue 700563002: Implementing directional text selection handles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@new_assets_text

Patch Set: Removing the SelectionBound test from Android, since touch_editing_controller not included in Andro… Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/textfield/textfield.h

diff --git a/ui/views/controls/textfield/textfield.h b/ui/views/controls/textfield/textfield.h

index 7347d95b387540fd6388b88ea9f3352ee65c8ecc..f488ca2707e02159ca7a569ae0d000420180dff0 100644

--- a/ui/views/controls/textfield/textfield.h

+++ b/ui/views/controls/textfield/textfield.h

@@ -257,7 +257,8 @@ class VIEWS_EXPORT Textfield : public View,

// ui::TouchEditable overrides:

void SelectRect(const gfx::Point& start, const gfx::Point& end) override;

void MoveCaretTo(const gfx::Point& point) override;

- void GetSelectionEndPoints(gfx::Rect* p1, gfx::Rect* p2) override;

+ void GetSelectionEndPoints(ui::SelectionBound* anchor,

+ ui::SelectionBound* focus) override;

gfx::Rect GetBounds() override;

gfx::NativeView GetNativeView() const override;

void ConvertPointToScreen(gfx::Point* point) override;

« no previous file with comments | « ui/resources/ui_resources.grd ('k') | ui/views/controls/textfield/textfield.cc » ('j') | no next file with comments »