content/browser/web_contents/touch_editable_impl_aura.h - Issue 700563002: Implementing directional text selection handles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/touch_editable_impl_aura.h

Issue 700563002: Implementing directional text selection handles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@new_assets_text

Patch Set: Removing the SelectionBound test from Android, since touch_editing_controller not included in Andro… Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.cc ('k') | content/browser/web_contents/touch_editable_impl_aura.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/touch_editable_impl_aura.h

diff --git a/content/browser/web_contents/touch_editable_impl_aura.h b/content/browser/web_contents/touch_editable_impl_aura.h

index 050d559124b133a806b3275d4f6a041041f04409..b42d966b72e1ef9d4afd150017f5f6a7c7736dae 100644

--- a/content/browser/web_contents/touch_editable_impl_aura.h

+++ b/content/browser/web_contents/touch_editable_impl_aura.h

@@ -44,8 +44,8 @@ class CONTENT_EXPORT TouchEditableImplAura

// Overridden from RenderWidgetHostViewAura::TouchEditingClient.

void StartTouchEditing() override;

void EndTouchEditing(bool quick) override;

- void OnSelectionOrCursorChanged(const gfx::Rect& anchor,

- const gfx::Rect& focus) override;

+ void OnSelectionOrCursorChanged(const ui::SelectionBound& anchor,

+ const ui::SelectionBound& focus) override;

void OnTextInputTypeChanged(ui::TextInputType type) override;

bool HandleInputEvent(const ui::Event* event) override;

void GestureEventAck(int gesture_event_type) override;

@@ -55,7 +55,8 @@ class CONTENT_EXPORT TouchEditableImplAura

// Overridden from ui::TouchEditable:

void SelectRect(const gfx::Point& start, const gfx::Point& end) override;

void MoveCaretTo(const gfx::Point& point) override;

- void GetSelectionEndPoints(gfx::Rect* p1, gfx::Rect* p2) override;

+ void GetSelectionEndPoints(ui::SelectionBound* anchor,

+ ui::SelectionBound* focus) override;

gfx::Rect GetBounds() override;

gfx::NativeView GetNativeView() const override;

void ConvertPointToScreen(gfx::Point* point) override;

@@ -81,9 +82,9 @@ class CONTENT_EXPORT TouchEditableImplAura

void Cleanup();

- // Rectangles for the selection anchor and focus.

- gfx::Rect selection_anchor_rect_;

- gfx::Rect selection_focus_rect_;

+ // Bounds for the selection.

+ ui::SelectionBound selection_anchor_;

+ ui::SelectionBound selection_focus_;

// The current text input type.

ui::TextInputType text_input_type_;