Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2349)

Unified Diff: content/browser/web_contents/touch_editable_impl_aura.h

Issue 700563002: Implementing directional text selection handles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@new_assets_text
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/touch_editable_impl_aura.h
diff --git a/content/browser/web_contents/touch_editable_impl_aura.h b/content/browser/web_contents/touch_editable_impl_aura.h
index 050d559124b133a806b3275d4f6a041041f04409..b42d966b72e1ef9d4afd150017f5f6a7c7736dae 100644
--- a/content/browser/web_contents/touch_editable_impl_aura.h
+++ b/content/browser/web_contents/touch_editable_impl_aura.h
@@ -44,8 +44,8 @@ class CONTENT_EXPORT TouchEditableImplAura
// Overridden from RenderWidgetHostViewAura::TouchEditingClient.
void StartTouchEditing() override;
void EndTouchEditing(bool quick) override;
- void OnSelectionOrCursorChanged(const gfx::Rect& anchor,
- const gfx::Rect& focus) override;
+ void OnSelectionOrCursorChanged(const ui::SelectionBound& anchor,
+ const ui::SelectionBound& focus) override;
void OnTextInputTypeChanged(ui::TextInputType type) override;
bool HandleInputEvent(const ui::Event* event) override;
void GestureEventAck(int gesture_event_type) override;
@@ -55,7 +55,8 @@ class CONTENT_EXPORT TouchEditableImplAura
// Overridden from ui::TouchEditable:
void SelectRect(const gfx::Point& start, const gfx::Point& end) override;
void MoveCaretTo(const gfx::Point& point) override;
- void GetSelectionEndPoints(gfx::Rect* p1, gfx::Rect* p2) override;
+ void GetSelectionEndPoints(ui::SelectionBound* anchor,
+ ui::SelectionBound* focus) override;
gfx::Rect GetBounds() override;
gfx::NativeView GetNativeView() const override;
void ConvertPointToScreen(gfx::Point* point) override;
@@ -81,9 +82,9 @@ class CONTENT_EXPORT TouchEditableImplAura
void Cleanup();
- // Rectangles for the selection anchor and focus.
- gfx::Rect selection_anchor_rect_;
- gfx::Rect selection_focus_rect_;
+ // Bounds for the selection.
+ ui::SelectionBound selection_anchor_;
+ ui::SelectionBound selection_focus_;
// The current text input type.
ui::TextInputType text_input_type_;

Powered by Google App Engine
This is Rietveld 408576698