Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.h

Issue 700563002: Implementing directional text selection handles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@new_assets_text
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura.h
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.h b/content/browser/renderer_host/render_widget_host_view_aura.h
index 81e794383f494de5966a3f87e7b6b4a05983c1bb..6c5b8ae7da8fe5782f9f5b92dfe5ecf2c4626c73 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.h
+++ b/content/browser/renderer_host/render_widget_host_view_aura.h
@@ -29,6 +29,7 @@
#include "ui/aura/window_delegate.h"
#include "ui/aura/window_tree_host_observer.h"
#include "ui/base/ime/text_input_client.h"
+#include "ui/base/touch/touch_editing_controller.h"
#include "ui/gfx/display_observer.h"
#include "ui/gfx/insets.h"
#include "ui/gfx/rect.h"
@@ -101,8 +102,9 @@ class CONTENT_EXPORT RenderWidgetHostViewAura
virtual void EndTouchEditing(bool quick) = 0;
// Notifies the client that the selection bounds need to be updated.
- virtual void OnSelectionOrCursorChanged(const gfx::Rect& anchor,
- const gfx::Rect& focus) = 0;
+ virtual void OnSelectionOrCursorChanged(
+ const ui::SelectionBound& anchor,
+ const ui::SelectionBound& focus) = 0;
// Notifies the client that the current text input type as changed.
virtual void OnTextInputTypeChanged(ui::TextInputType type) = 0;
@@ -525,9 +527,9 @@ class CONTENT_EXPORT RenderWidgetHostViewAura
int text_input_flags_;
bool can_compose_inline_;
- // Rectangles for the selection anchor and focus.
- gfx::Rect selection_anchor_rect_;
- gfx::Rect selection_focus_rect_;
+ // Bounds for the selection.
+ ui::SelectionBound selection_anchor_;
+ ui::SelectionBound selection_focus_;
// The current composition character bounds.
std::vector<gfx::Rect> composition_character_bounds_;

Powered by Google App Engine
This is Rietveld 408576698