Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 70053003: Delete IBusEngineService. (Closed)

Created:
7 years, 1 month ago by Hiro Komatsu
Modified:
7 years, 1 month ago
Reviewers:
satorux1, Seigo Nonaka
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Delete IBusEngineService. This patch focuses on the deletion of IBusEngineService keeping the logic as-is. BUG=275262 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235648

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : Update comments based on the review. #

Total comments: 4

Patch Set 4 : Modify comments based on the review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -388 lines) Patch
M chrome/browser/chromeos/input_method/input_method_engine_ibus.h View 1 4 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_ibus.cc View 1 2 3 11 chunks +34 lines, -37 lines 0 comments Download
M chromeos/chromeos.gyp View 2 chunks +0 lines, -4 lines 0 comments Download
D chromeos/dbus/ibus/ibus_engine_service.h View 1 chunk +0 lines, -73 lines 0 comments Download
D chromeos/dbus/ibus/ibus_engine_service.cc View 1 chunk +0 lines, -90 lines 0 comments Download
D chromeos/dbus/ibus/mock_ibus_engine_service.h View 1 chunk +0 lines, -94 lines 0 comments Download
D chromeos/dbus/ibus/mock_ibus_engine_service.cc View 1 chunk +0 lines, -79 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Hiro Komatsu
This patch depends on: * https://codereview.chromium.org/67313006/ * https://codereview.chromium.org/68503002/ * https://codereview.chromium.org/68603002/ Satoru, please review this patch ...
7 years, 1 month ago (2013-11-12 07:55:20 UTC) #1
Seigo Nonaka
lgtm
7 years, 1 month ago (2013-11-12 12:31:05 UTC) #2
satorux1
https://codereview.chromium.org/70053003/diff/50001/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc File chrome/browser/chromeos/input_method/input_method_engine_ibus.cc (right): https://codereview.chromium.org/70053003/diff/50001/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc#newcode39 chrome/browser/chromeos/input_method/input_method_engine_ibus.cc:39: void UpdatePreedit(const IBusText& ibus_text, function comment is missing. https://codereview.chromium.org/70053003/diff/50001/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc#newcode48 ...
7 years, 1 month ago (2013-11-13 14:22:07 UTC) #3
Hiro Komatsu
https://codereview.chromium.org/70053003/diff/50001/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc File chrome/browser/chromeos/input_method/input_method_engine_ibus.cc (right): https://codereview.chromium.org/70053003/diff/50001/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc#newcode39 chrome/browser/chromeos/input_method/input_method_engine_ibus.cc:39: void UpdatePreedit(const IBusText& ibus_text, On 2013/11/13 14:22:07, satorux1 wrote: ...
7 years, 1 month ago (2013-11-14 01:55:24 UTC) #4
Hiro Komatsu
On 2013/11/14 01:55:24, Hiro Komatsu wrote: > https://codereview.chromium.org/70053003/diff/50001/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc > File chrome/browser/chromeos/input_method/input_method_engine_ibus.cc (right): > > https://codereview.chromium.org/70053003/diff/50001/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc#newcode39 ...
7 years, 1 month ago (2013-11-15 02:12:16 UTC) #5
satorux1
lgtm https://codereview.chromium.org/70053003/diff/90001/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc File chrome/browser/chromeos/input_method/input_method_engine_ibus.cc (right): https://codereview.chromium.org/70053003/diff/90001/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc#newcode39 chrome/browser/chromeos/input_method/input_method_engine_ibus.cc:39: // Notices InputContextHandler that the preedit is changed. ...
7 years, 1 month ago (2013-11-15 02:15:49 UTC) #6
Hiro Komatsu
committing... https://codereview.chromium.org/70053003/diff/90001/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc File chrome/browser/chromeos/input_method/input_method_engine_ibus.cc (right): https://codereview.chromium.org/70053003/diff/90001/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc#newcode39 chrome/browser/chromeos/input_method/input_method_engine_ibus.cc:39: // Notices InputContextHandler that the preedit is changed. ...
7 years, 1 month ago (2013-11-15 02:32:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/komatsu@chromium.org/70053003/200001
7 years, 1 month ago (2013-11-15 04:13:22 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=190558
7 years, 1 month ago (2013-11-15 07:14:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/komatsu@chromium.org/70053003/200001
7 years, 1 month ago (2013-11-15 16:11:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/komatsu@chromium.org/70053003/200001
7 years, 1 month ago (2013-11-15 22:18:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/komatsu@chromium.org/70053003/200001
7 years, 1 month ago (2013-11-16 00:52:06 UTC) #12
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 07:48:56 UTC) #13
Message was sent while issue was closed. 
Change committed as 235648

Powered by Google App Engine
This is Rietveld 408576698