Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: src/arm/full-codegen-arm.cc

Issue 700523003: Classes: Partial fix for constructor not calling super (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | src/parser.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm/full-codegen-arm.cc
diff --git a/src/arm/full-codegen-arm.cc b/src/arm/full-codegen-arm.cc
index 1710b609dc68740a60cb1984cdbb9223415e99f5..c51940d9061f86579c16849e551ed7f36414cd74 100644
--- a/src/arm/full-codegen-arm.cc
+++ b/src/arm/full-codegen-arm.cc
@@ -451,7 +451,9 @@ void FullCodeGenerator::EmitReturnSequence() {
// sequence.
{ Assembler::BlockConstPoolScope block_const_pool(masm_);
int32_t sp_delta = (info_->scope()->num_parameters() + 1) * kPointerSize;
- CodeGenerator::RecordPositions(masm_, function()->end_position() - 1);
+ if (function()->end_position() != RelocInfo::kNoPosition) {
arv (Not doing code reviews) 2014/11/07 00:03:04 I'm going to see if I can use the position of the
+ CodeGenerator::RecordPositions(masm_, function()->end_position() - 1);
+ }
// TODO(svenpanne) The code below is sometimes 4 words, sometimes 5!
PredictableCodeSizeScope predictable(masm_, -1);
__ RecordJSReturn();
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | src/parser.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698