Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(60)

Issue 7005023: Merge 86132 - 2011-05-10 MORITA Hajime <morrita@google.com> (Closed)

Created:
8 years, 1 month ago by gmorrita
Modified:
8 years, 1 month ago
Reviewers:
gmorrita
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/742/
Visibility:
Public.

Description

Merge 86132 - 2011-05-10 MORITA Hajime <morrita@google.com>; Reviewed by Ryosuke Niwa. REGRESSION(r73886): Frequent crashes in replaceSelectionWithFragment https://bugs.webkit.org/show_bug.cgi?id=60090 SpellChecker uses TextCheckerClient, which belongs Page object, which is possibly destroyed during SpellChecker's lifetime. This change added to a guard before using TextCheckerClient to ensure it being live. No new tests, this is a speculative fix for a real crash. * editing/Editor.cpp: (WebCore::Editor::Editor): * editing/SpellChecker.cpp: (WebCore::SpellChecker::SpellChecker): (WebCore::SpellChecker::client): (WebCore::SpellChecker::canCheckAsynchronously): (WebCore::SpellChecker::requestCheckingFor): * editing/SpellChecker.h: TBR=levin@chromium.org BUG=82238 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86212

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M Source/WebCore/editing/Editor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/editing/SpellChecker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/editing/SpellChecker.cpp View 5 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
gmorrita
8 years, 1 month ago (2011-05-11 05:25:07 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698