Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 7005009: Merge 84611 - <rdar://problem/9322486> REGRESSION (r83397): Default controls fade out when playin... (Closed)

Created:
8 years, 1 month ago by kerz_chromium
Modified:
8 years, 1 month ago
Reviewers:
mitz
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/742/
Visibility:
Public.

Description

Merge 84611 - <rdar://problem/9322486> REGRESSION (r83397): Default controls fade out when playing audio-only media https://bugs.webkit.org/show_bug.cgi?id=59180 Reviewed by Maciej Stachowiak. Source/WebCore: Test: media/audio-controls-do-not-fade-out.html * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::playbackProgressTimerFired): Only start fading out the controls if there is a video track. LayoutTests: * media/audio-controls-do-not-fade-out-expected.txt: Added. * media/audio-controls-do-not-fade-out.html: Added. TBR=mitz@apple.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86181

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +11 lines, -1 line 0 comments Download
A + LayoutTests/media/audio-controls-do-not-fade-out.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/media/audio-controls-do-not-fade-out-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/html/HTMLMediaElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
kerz_chromium
8 years, 1 month ago (2011-05-10 21:43:18 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698