Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 700493002: Fix workdir feature for release scripts. (Closed)

Created:
6 years, 1 month ago by Michael Achenbach
Modified:
6 years, 1 month ago
Reviewers:
tandrii(chromium)
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix workdir feature for release scripts. BUG=408523 LOG=n TEST=script_test.py TBR=tandrii@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25058

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -15 lines) Patch
M tools/push-to-trunk/auto_push.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/push-to-trunk/auto_roll.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/push-to-trunk/common_includes.py View 3 chunks +14 lines, -13 lines 0 comments Download
M tools/push-to-trunk/test_scripts.py View 3 chunks +17 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Michael Achenbach
PTAL
6 years, 1 month ago (2014-11-03 09:29:39 UTC) #2
Michael Achenbach
Committed patchset #2 (id:20001) manually as 25058 (presubmit successful).
6 years, 1 month ago (2014-11-03 09:31:25 UTC) #3
tandrii(chromium)
6 years, 1 month ago (2014-11-03 15:02:50 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698