Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 700463005: Update CSS to delay change in visibility so it matches the overlay (Closed)

Created:
6 years, 1 month ago by hcarmona
Modified:
6 years, 1 month ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update CSS to delay change in visibility so it matches the overlay BUG=429652 Committed: https://crrev.com/46e4793edc7a72932bbbbe8e0ceadac08ff7372a Cr-Commit-Position: refs/heads/master@{#302658}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/resources/print_preview/previewarea/preview_area.css View 1 chunk +7 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
hcarmona
Change in CSS to fix regression from previous change to print preview. This change will ...
6 years, 1 month ago (2014-11-04 18:27:41 UTC) #2
Aleksey Shlyapnikov
lgtm
6 years, 1 month ago (2014-11-04 18:46:20 UTC) #3
Dan Beam
https://codereview.chromium.org/700463005/diff/1/chrome/browser/resources/print_preview/previewarea/preview_area.css File chrome/browser/resources/print_preview/previewarea/preview_area.css (right): https://codereview.chromium.org/700463005/diff/1/chrome/browser/resources/print_preview/previewarea/preview_area.css#newcode89 chrome/browser/resources/print_preview/previewarea/preview_area.css:89: transition: visibility 100ms linear 100ms; i'm amazed visibility is ...
6 years, 1 month ago (2014-11-04 19:15:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/700463005/1
6 years, 1 month ago (2014-11-04 19:32:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-04 20:41:15 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 20:42:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46e4793edc7a72932bbbbe8e0ceadac08ff7372a
Cr-Commit-Position: refs/heads/master@{#302658}

Powered by Google App Engine
This is Rietveld 408576698