Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 700453003: Revert of Make extensions that desire to act pop out if in overflow (Closed)

Created:
6 years, 1 month ago by benwells
Modified:
6 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Make extensions that desire to act pop out if in overflow (patchset #6 id:200001 of https://codereview.chromium.org/675023002/) Reason for revert: Suspect this patch of causing errors on linux valgrind for LocationBarControllerUnitTest.NavigationClearsState. http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%285%29/builds/31337 Sample valgrind output: Suppression (error hash=#606630BA25518095#): For more info on using suppressions see http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff#TOC-Suppressing-memory-reports { <insert_a_suppression_name_here> Memcheck:Unaddressable fun:_ZN16ExtensionService21NotifyExtensionLoadedEPKN10extensions9ExtensionE fun:_ZN16ExtensionService12AddExtensionEPKN10extensions9ExtensionE fun:_ZN10extensions12_GLOBAL__N_129LocationBarControllerUnitTest12AddExtensionEbRKSs fun:_ZN10extensions12_GLOBAL__N_156LocationBarControllerUnitTest_NavigationClearsState_Test8TestBodyEv } Original issue's description: > Make extensions that desire to act pop out if in overflow > > If an extension desires to act, it should pop itself out of > the overflow menu. There should also be a visual queue for > extensions that are already visible, but what exactly that > should be is still being discussed. > > BUG=417441 > > Committed: https://crrev.com/d604171517135387ca3b4c33d7f1774c8d2d38b0 > Cr-Commit-Position: refs/heads/master@{#302511} TBR=finnur@chromium.org,pkasting@chromium.org,rdevlin.cronin@chromium.org NOTREECHECKS=true NOTRY=true BUG=417441 Committed: https://crrev.com/0af77c4ed12d6a0fa8485f2753fbaa414dae918b Cr-Commit-Position: refs/heads/master@{#302563}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -433 lines) Patch
M chrome/browser/extensions/extension_toolbar_model.h View 8 chunks +15 lines, -38 lines 0 comments Download
M chrome/browser/extensions/extension_toolbar_model.cc View 4 chunks +11 lines, -58 lines 0 comments Download
M chrome/browser/extensions/extension_toolbar_model_unittest.cc View 14 chunks +21 lines, -202 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.h View 3 chunks +3 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.cc View 13 chunks +33 lines, -109 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
benwells
Created Revert of Make extensions that desire to act pop out if in overflow
6 years, 1 month ago (2014-11-04 02:57:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/700453003/1
6 years, 1 month ago (2014-11-04 02:59:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-04 03:03:26 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 03:06:13 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0af77c4ed12d6a0fa8485f2753fbaa414dae918b
Cr-Commit-Position: refs/heads/master@{#302563}

Powered by Google App Engine
This is Rietveld 408576698