Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 700413002: [DocumentThreadableLoader] Rename notifyResponseReceived to reportResponseReceived (Closed)

Created:
6 years, 1 month ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 1 month ago
Reviewers:
Mike West
CC:
blink-reviews, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[DocumentThreadableLoader] Rename notifyResponseReceived to reportResponseReceived "notifySomething" style method naming is often used to notify its client about completion. This is just for inspector and console logging. It's surprising that we see a function looks like notifying completion called inside access control failure path. Use reportSomething that is often used to methods that report to inspector or writing some log. R=mkwst BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184905

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M Source/core/loader/DocumentThreadableLoader.h View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/loader/DocumentThreadableLoader.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
tyoshino (SeeGerritForStatus)
6 years, 1 month ago (2014-11-06 06:22:20 UTC) #2
Mike West
LGTM.
6 years, 1 month ago (2014-11-06 07:58:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/700413002/1
6 years, 1 month ago (2014-11-06 08:05:40 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-06 09:48:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184905

Powered by Google App Engine
This is Rietveld 408576698