Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 7004021: Fixed handling of different decimal separators on DigitList::set(). (Closed)

Created:
9 years, 7 months ago by Joao da Silva
Modified:
9 years, 6 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews, ahendrickson
Visibility:
Public.

Description

Fixed handling of different decimal separators on DigitList::set(). BUG=chromium:60476 TEST=chromium unit_tests:TimeFormat.FAILS_DecimalPointNotDot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88321

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -9 lines) Patch
M README.chromium View 1 1 chunk +7 lines, -0 lines 0 comments Download
A patches/nan.patch View 1 1 chunk +65 lines, -0 lines 0 comments Download
M source/i18n/digitlst.cpp View 1 4 chunks +24 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Joao da Silva
This bug on ICU causes the estimated download time to show "NaN secs/mins left" on ...
9 years, 7 months ago (2011-05-11 14:33:59 UTC) #1
jungshik at Google
THank you for the patch. Pls, bear with me while I digest the implication of ...
9 years, 7 months ago (2011-05-12 17:25:52 UTC) #2
Joao da Silva
Alright, I'll be looking forward for your input. Please notice that I couldn't reproduce the ...
9 years, 7 months ago (2011-05-12 17:33:37 UTC) #3
jungshik at Google
LGTM. Sorry that it took me so long. BTW, in README.chromium, can you add a ...
9 years, 6 months ago (2011-06-07 21:41:30 UTC) #4
Joao da Silva
9 years, 6 months ago (2011-06-08 11:37:43 UTC) #5
I updated the README and added the comment. Thanks for reviewing.

http://codereview.chromium.org/7004021/diff/1/source/i18n/digitlst.cpp
File source/i18n/digitlst.cpp (right):

http://codereview.chromium.org/7004021/diff/1/source/i18n/digitlst.cpp#newcod...
source/i18n/digitlst.cpp:738: *decimalPt = '.';
On 2011/06/07 21:41:30, Jungshik Shin wrote:
> nit: can you add a comment explaining why you need to do this? 
> That is, uprv_decNumberFromString assumes that '.' is used for decimal
> mark/'point'. 

Done.

Powered by Google App Engine
This is Rietveld 408576698