Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: util/posix/process_util_test.cc

Issue 700383007: Use implicit_cast<> instead of static_cast<> whenever possible (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "util/posix/process_util.h" 15 #include "util/posix/process_util.h"
16 16
17 #include <crt_externs.h> 17 #include <crt_externs.h>
18 #include <unistd.h> 18 #include <unistd.h>
19 19
20 #include <string> 20 #include <string>
21 #include <vector> 21 #include <vector>
22 22
23 #include "base/basictypes.h"
23 #include "gtest/gtest.h" 24 #include "gtest/gtest.h"
24 25
25 namespace crashpad { 26 namespace crashpad {
26 namespace test { 27 namespace test {
27 namespace { 28 namespace {
28 29
29 TEST(ProcessUtil, ProcessArgumentsForPID) { 30 TEST(ProcessUtil, ProcessArgumentsForPID) {
30 std::vector<std::string> argv; 31 std::vector<std::string> argv;
31 ASSERT_TRUE(ProcessArgumentsForPID(getpid(), &argv)); 32 ASSERT_TRUE(ProcessArgumentsForPID(getpid(), &argv));
32 33
33 // gtest argv processing scrambles argv, but it leaves argc and argv[0] 34 // gtest argv processing scrambles argv, but it leaves argc and argv[0]
34 // intact, so test those. 35 // intact, so test those.
35 36
36 int argc = static_cast<int>(argv.size()); 37 int argc = implicit_cast<int>(argv.size());
37 int expect_argc = *_NSGetArgc(); 38 int expect_argc = *_NSGetArgc();
38 EXPECT_EQ(expect_argc, argc); 39 EXPECT_EQ(expect_argc, argc);
39 40
40 ASSERT_GE(expect_argc, 1); 41 ASSERT_GE(expect_argc, 1);
41 ASSERT_GE(argc, 1); 42 ASSERT_GE(argc, 1);
42 43
43 char** expect_argv = *_NSGetArgv(); 44 char** expect_argv = *_NSGetArgv();
44 EXPECT_EQ(std::string(expect_argv[0]), argv[0]); 45 EXPECT_EQ(std::string(expect_argv[0]), argv[0]);
45 } 46 }
46 47
47 } // namespace 48 } // namespace
48 } // namespace test 49 } // namespace test
49 } // namespace crashpad 50 } // namespace crashpad
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698