Use implicit_cast<> instead of static_cast<> whenever possible

util/mach/symbolic_constants_mach_test.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 519 matching lines @@
 }
 
 const struct {
   exception_behavior_t behavior;
   const char* full_name;
   const char* short_name;
 } kExceptionBehaviorTestData[] = {
     {EXCEPTION_DEFAULT, "EXCEPTION_DEFAULT", "DEFAULT"},
     {EXCEPTION_STATE, "EXCEPTION_STATE", "STATE"},
     {EXCEPTION_STATE_IDENTITY, "EXCEPTION_STATE_IDENTITY", "STATE_IDENTITY"},
-    {static_cast<exception_behavior_t>(EXCEPTION_DEFAULT |
-                                       MACH_EXCEPTION_CODES),
+    {implicit_cast<exception_behavior_t>(EXCEPTION_DEFAULT |
+                                         MACH_EXCEPTION_CODES),
      "EXCEPTION_DEFAULT|MACH_EXCEPTION_CODES",
      "DEFAULT|MACH"},
-    {static_cast<exception_behavior_t>(EXCEPTION_STATE |
-                                       MACH_EXCEPTION_CODES),
+    {implicit_cast<exception_behavior_t>(EXCEPTION_STATE |
+                                         MACH_EXCEPTION_CODES),
      "EXCEPTION_STATE|MACH_EXCEPTION_CODES",
      "STATE|MACH"},
-    {static_cast<exception_behavior_t>(EXCEPTION_STATE_IDENTITY |
-                                       MACH_EXCEPTION_CODES),
+    {implicit_cast<exception_behavior_t>(EXCEPTION_STATE_IDENTITY |
+                                         MACH_EXCEPTION_CODES),
      "EXCEPTION_STATE_IDENTITY|MACH_EXCEPTION_CODES",
      "STATE_IDENTITY|MACH"},
 };
 
 struct ConvertExceptionBehaviorTraits {
   using ValueType = exception_behavior_t;
   static std::string SomethingToString(
       ValueType value,
       SymbolicConstantToStringOptions options) {
     return ExceptionBehaviorToString(value, options);
@@ skipping 132 matching lines @@
     }
   }
 
   const struct {
     const char* string;
     StringToSymbolicConstantOptions options;
     exception_behavior_t behavior;
   } kNonCanonicalTestData[] = {
       {"MACH_EXCEPTION_CODES|EXCEPTION_STATE_IDENTITY",
        kAllowFullName,
-       static_cast<exception_behavior_t>(EXCEPTION_STATE_IDENTITY |
-                                         MACH_EXCEPTION_CODES)},
+       implicit_cast<exception_behavior_t>(EXCEPTION_STATE_IDENTITY |
+                                           MACH_EXCEPTION_CODES)},
       {"MACH|STATE_IDENTITY",
        kAllowShortName,
-       static_cast<exception_behavior_t>(EXCEPTION_STATE_IDENTITY |
-                                         MACH_EXCEPTION_CODES)},
+       implicit_cast<exception_behavior_t>(EXCEPTION_STATE_IDENTITY |
+                                           MACH_EXCEPTION_CODES)},
       {"MACH_EXCEPTION_CODES|STATE",
        kAllowFullName | kAllowShortName,
-       static_cast<exception_behavior_t>(EXCEPTION_STATE |
-                                         MACH_EXCEPTION_CODES)},
+       implicit_cast<exception_behavior_t>(EXCEPTION_STATE |
+                                           MACH_EXCEPTION_CODES)},
       {"MACH|EXCEPTION_STATE",
        kAllowFullName | kAllowShortName,
-       static_cast<exception_behavior_t>(EXCEPTION_STATE |
-                                         MACH_EXCEPTION_CODES)},
+       implicit_cast<exception_behavior_t>(EXCEPTION_STATE |
+                                           MACH_EXCEPTION_CODES)},
       {"3|MACH_EXCEPTION_CODES",
        kAllowFullName | kAllowNumber,
-       static_cast<exception_behavior_t>(MACH_EXCEPTION_CODES | 3)},
+       implicit_cast<exception_behavior_t>(MACH_EXCEPTION_CODES | 3)},
       {"MACH|0x2",
        kAllowShortName | kAllowNumber,
-       static_cast<exception_behavior_t>(MACH_EXCEPTION_CODES | 0x2)},
+       implicit_cast<exception_behavior_t>(MACH_EXCEPTION_CODES | 0x2)},
   };
 
   for (size_t index = 0; index < arraysize(kNonCanonicalTestData); ++index) {
     SCOPED_TRACE(base::StringPrintf("index %zu", index));
     TestStringToExceptionBehavior(kNonCanonicalTestData[index].string,
                                   kNonCanonicalTestData[index].options,
                                   true,
                                   kNonCanonicalTestData[index].behavior);
   }
 
@@ skipping 325 matching lines @@
     TestStringToThreadStateFlavor(base::StringPiece("FLAVOR_LIST_NEWS", 15),
                                   kAllowShortName,
                                   true,
                                   THREAD_STATE_FLAVOR_LIST_NEW);
   }
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace crashpad