Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: util/mac/launchd.mm

Issue 700383007: Use implicit_cast<> instead of static_cast<> whenever possible (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "util/mac/launchd.h" 15 #include "util/mac/launchd.h"
16 16
17 #import <Foundation/Foundation.h> 17 #import <Foundation/Foundation.h>
18 18
19 #include "base/basictypes.h"
19 #include "base/mac/foundation_util.h" 20 #include "base/mac/foundation_util.h"
20 #include "base/mac/scoped_launch_data.h" 21 #include "base/mac/scoped_launch_data.h"
21 #include "base/mac/scoped_cftyperef.h" 22 #include "base/mac/scoped_cftyperef.h"
22 #include "base/strings/sys_string_conversions.h" 23 #include "base/strings/sys_string_conversions.h"
23 24
24 namespace crashpad { 25 namespace crashpad {
25 26
26 launch_data_t CFPropertyToLaunchData(CFPropertyListRef property_cf) { 27 launch_data_t CFPropertyToLaunchData(CFPropertyListRef property_cf) {
27 @autoreleasepool { 28 @autoreleasepool {
28 // This function mixes Foundation and Core Foundation access to property 29 // This function mixes Foundation and Core Foundation access to property
29 // list elements according to which is more convenient and correct for any 30 // list elements according to which is more convenient and correct for any
30 // specific task. 31 // specific task.
31 32
32 launch_data_t data_launch = nullptr; 33 launch_data_t data_launch = nullptr;
33 CFTypeID type_id_cf = CFGetTypeID(property_cf); 34 CFTypeID type_id_cf = CFGetTypeID(property_cf);
34 35
35 if (type_id_cf == CFDictionaryGetTypeID()) { 36 if (type_id_cf == CFDictionaryGetTypeID()) {
36 NSDictionary* dictionary_ns = base::mac::CFToNSCast( 37 NSDictionary* dictionary_ns = base::mac::CFToNSCast(
37 base::mac::CFCastStrict<CFDictionaryRef>(property_cf)); 38 base::mac::CFCastStrict<CFDictionaryRef>(property_cf));
38 base::mac::ScopedLaunchData dictionary_launch( 39 base::mac::ScopedLaunchData dictionary_launch(
39 launch_data_alloc(LAUNCH_DATA_DICTIONARY)); 40 launch_data_alloc(LAUNCH_DATA_DICTIONARY));
40 41
41 for (NSString* key in dictionary_ns) { 42 for (NSString* key in dictionary_ns) {
42 if (![key isKindOfClass:[NSString class]]) { 43 if (![key isKindOfClass:[NSString class]]) {
43 return nullptr; 44 return nullptr;
44 } 45 }
45 46
46 CFPropertyListRef value_cf = 47 CFPropertyListRef value_cf =
47 static_cast<CFPropertyListRef>([dictionary_ns objectForKey:key]); 48 implicit_cast<CFPropertyListRef>([dictionary_ns objectForKey:key]);
48 launch_data_t value_launch = CFPropertyToLaunchData(value_cf); 49 launch_data_t value_launch = CFPropertyToLaunchData(value_cf);
49 if (!value_launch) { 50 if (!value_launch) {
50 return nullptr; 51 return nullptr;
51 } 52 }
52 53
53 launch_data_dict_insert( 54 launch_data_dict_insert(
54 dictionary_launch, value_launch, [key UTF8String]); 55 dictionary_launch, value_launch, [key UTF8String]);
55 } 56 }
56 57
57 data_launch = dictionary_launch.release(); 58 data_launch = dictionary_launch.release();
58 59
59 } else if (type_id_cf == CFArrayGetTypeID()) { 60 } else if (type_id_cf == CFArrayGetTypeID()) {
60 NSArray* array_ns = base::mac::CFToNSCast( 61 NSArray* array_ns = base::mac::CFToNSCast(
61 base::mac::CFCastStrict<CFArrayRef>(property_cf)); 62 base::mac::CFCastStrict<CFArrayRef>(property_cf));
62 base::mac::ScopedLaunchData array_launch( 63 base::mac::ScopedLaunchData array_launch(
63 launch_data_alloc(LAUNCH_DATA_ARRAY)); 64 launch_data_alloc(LAUNCH_DATA_ARRAY));
64 size_t index = 0; 65 size_t index = 0;
65 66
66 for (id element_ns in array_ns) { 67 for (id element_ns in array_ns) {
67 CFPropertyListRef element_cf = 68 CFPropertyListRef element_cf =
68 static_cast<CFPropertyListRef>(element_ns); 69 implicit_cast<CFPropertyListRef>(element_ns);
69 launch_data_t element_launch = CFPropertyToLaunchData(element_cf); 70 launch_data_t element_launch = CFPropertyToLaunchData(element_cf);
70 if (!element_launch) { 71 if (!element_launch) {
71 return nullptr; 72 return nullptr;
72 } 73 }
73 74
74 launch_data_array_set_index(array_launch, element_launch, index++); 75 launch_data_array_set_index(array_launch, element_launch, index++);
75 } 76 }
76 77
77 data_launch = array_launch.release(); 78 data_launch = array_launch.release();
78 79
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 CFCopyTypeIDDescription(type_id_cf)); 133 CFCopyTypeIDDescription(type_id_cf));
133 DLOG(ERROR) << "unable to convert CFTypeID " << type_id_cf << " (" 134 DLOG(ERROR) << "unable to convert CFTypeID " << type_id_cf << " ("
134 << base::SysCFStringRefToUTF8(type_name_cf) << ")"; 135 << base::SysCFStringRefToUTF8(type_name_cf) << ")";
135 } 136 }
136 137
137 return data_launch; 138 return data_launch;
138 } 139 }
139 } 140 }
140 141
141 } // namespace crashpad 142 } // namespace crashpad
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698