Use implicit_cast<> instead of static_cast<> whenever possible

snapshot/mac/mach_o_image_reader_test.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 492 matching lines @@
   const MachHeader* mh_execute_header =
       reinterpret_cast<MachHeader*>(dlsym(RTLD_MAIN_ONLY, MH_EXECUTE_SYM));
   ASSERT_NE(nullptr, mh_execute_header);
   mach_vm_address_t mh_execute_header_address =
       reinterpret_cast<mach_vm_address_t>(mh_execute_header);
 
   MachOImageReader image_reader;
   ASSERT_TRUE(image_reader.Initialize(
       &process_reader, mh_execute_header_address, "executable"));
 
-  EXPECT_EQ(static_cast<uint32_t>(MH_EXECUTE), image_reader.FileType());
+  EXPECT_EQ(implicit_cast<uint32_t>(MH_EXECUTE), image_reader.FileType());
 
   // The main executable has image index 0.
   intptr_t image_slide = _dyld_get_image_vmaddr_slide(0);
 
   ASSERT_NO_FATAL_FAILURE(ExpectMachImage(mh_execute_header,
                                           mh_execute_header_address,
                                           image_slide,
                                           &image_reader,
                                           true));
 
@@ skipping 25 matching lines @@
         reinterpret_cast<const MachHeader*>(_dyld_get_image_header(index));
     mach_vm_address_t image_address =
         reinterpret_cast<mach_vm_address_t>(mach_header);
 
     MachOImageReader image_reader;
     ASSERT_TRUE(
         image_reader.Initialize(&process_reader, image_address, image_name));
 
     uint32_t file_type = image_reader.FileType();
     if (index == 0) {
-      EXPECT_EQ(static_cast<uint32_t>(MH_EXECUTE), file_type);
+      EXPECT_EQ(implicit_cast<uint32_t>(MH_EXECUTE), file_type);
     } else {
       EXPECT_TRUE(file_type == MH_DYLIB || file_type == MH_BUNDLE);
     }
 
     intptr_t image_slide = _dyld_get_image_vmaddr_slide(index);
     ASSERT_NO_FATAL_FAILURE(ExpectMachImage(
         mach_header, image_address, image_slide, &image_reader, false));
 
     ASSERT_NO_FATAL_FAILURE(ExpectSymbolTable(mach_header, &image_reader));
   }
@@ skipping 11 matching lines @@
     // dyld_all_image_infos::dyldImageLoadAddress is poorly-declared too.
     const MachHeader* mach_header = reinterpret_cast<const MachHeader*>(
         dyld_image_infos->dyldImageLoadAddress);
     mach_vm_address_t image_address =
         reinterpret_cast<mach_vm_address_t>(mach_header);
 
     MachOImageReader image_reader;
     ASSERT_TRUE(
         image_reader.Initialize(&process_reader, image_address, "dyld"));
 
-    EXPECT_EQ(static_cast<uint32_t>(MH_DYLINKER), image_reader.FileType());
+    EXPECT_EQ(implicit_cast<uint32_t>(MH_DYLINKER), image_reader.FileType());
 
     // There’s no good API to get dyld’s slide, so don’t bother checking it.
     ASSERT_NO_FATAL_FAILURE(ExpectMachImage(
         mach_header, image_address, kSlideUnknown, &image_reader, false));
 
     ASSERT_NO_FATAL_FAILURE(ExpectSymbolTable(mach_header, &image_reader));
   }
 
 #if MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_7
   // If dyld is new enough to record UUIDs, check the UUID of any module that
@@ skipping 29 matching lines @@
       image_reader.UUID(&actual_uuid);
       EXPECT_EQ(expected_uuid, actual_uuid);
     }
   }
 #endif
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace crashpad