Use implicit_cast<> instead of static_cast<> whenever possible

minidump/minidump_system_info_writer.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 16 matching lines @@
 namespace {
 
 uint64_t AMD64FeaturesFromSystemSnapshot(
     const SystemSnapshot* system_snapshot) {
 #define ADD_FEATURE(minidump_bit) (UINT64_C(1) << (minidump_bit))
 
   // Features for which no cpuid bits are present, but that always exist on
   // x86_64. cmpxchg is supported on 486 and later.
   uint64_t minidump_features = ADD_FEATURE(PF_COMPARE_EXCHANGE_DOUBLE);
 
-#define MAP_FEATURE(features, cpuid_bit, minidump_bit)                    \
-do {                                                                      \
-  if ((features) & (static_cast<decltype(features)>(1) << (cpuid_bit))) { \
-    minidump_features |= ADD_FEATURE(minidump_bit);                       \
-  }                                                                       \
-} while (false)
+#define MAP_FEATURE(features, cpuid_bit, minidump_bit)                        \
+  do {                                                                        \
+    if ((features) & (implicit_cast<decltype(features)>(1) << (cpuid_bit))) { \
+      minidump_features |= ADD_FEATURE(minidump_bit);                         \
+    }                                                                         \
+  } while (false)
 
 #define F_TSC 4
 #define F_PAE 6
 #define F_MMX 23
 #define F_SSE 25
 #define F_SSE2 26
 #define F_SSE3 32
 #define F_CX16 45
 #define F_XSAVE 58
 #define F_RDRAND 62
@@ skipping 68 matching lines @@
       cpu_architecture = kMinidumpCPUArchitectureAMD64;
       break;
     default:
       NOTREACHED();
       cpu_architecture = kMinidumpCPUArchitectureUnknown;
       break;
   }
   SetCPUArchitecture(cpu_architecture);
 
   uint32_t cpu_revision = system_snapshot->CPURevision();
-  SetCPULevelAndRevision(
-      (cpu_revision & 0xffff0000) >> 16, cpu_revision & 0x0000ffff);
+  SetCPULevelAndRevision((cpu_revision & 0xffff0000) >> 16,
+                         cpu_revision & 0x0000ffff);
   SetCPUCount(system_snapshot->CPUCount());
 
   if (cpu_architecture == kMinidumpCPUArchitectureX86) {
     std::string cpu_vendor = system_snapshot->CPUVendor();
     SetCPUX86VendorString(cpu_vendor);
 
     // The minidump file format only has room for the bottom 32 bits of CPU
     // features and extended CPU features.
     SetCPUX86VersionAndFeatures(system_snapshot->CPUX86Signature(),
                                 system_snapshot->CPUX86Features() & 0xffffffff);
@@ skipping 144 matching lines @@
   DCHECK_EQ(state(), kStateWritable);
 
   return file_writer->Write(&system_info_, sizeof(system_info_));
 }
 
 MinidumpStreamType MinidumpSystemInfoWriter::StreamType() const {
   return kMinidumpStreamTypeSystemInfo;
 }
 
 }  // namespace crashpad