Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Side by Side Diff: client/capture_context_mac_test.cc

Issue 700383007: Use implicit_cast<> instead of static_cast<> whenever possible (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | client/simple_string_dictionary.h » ('j') | client/simple_string_dictionary.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "client/capture_context_mac.h" 15 #include "client/capture_context_mac.h"
16 16
17 #include <mach/mach.h> 17 #include <mach/mach.h>
18 #include <stdint.h> 18 #include <stdint.h>
19 19
20 #include <algorithm> 20 #include <algorithm>
21 21
22 #include "base/basictypes.h"
22 #include "build/build_config.h" 23 #include "build/build_config.h"
23 #include "gtest/gtest.h" 24 #include "gtest/gtest.h"
24 25
25 namespace crashpad { 26 namespace crashpad {
26 namespace test { 27 namespace test {
27 namespace { 28 namespace {
28 29
29 // If the context structure has fields that tell whether it’s valid, such as 30 // If the context structure has fields that tell whether it’s valid, such as
30 // magic numbers or size fields, sanity-checks those fields for validity with 31 // magic numbers or size fields, sanity-checks those fields for validity with
31 // fatal gtest assertions. For other fields, where it’s possible to reason about 32 // fatal gtest assertions. For other fields, where it’s possible to reason about
32 // their validity based solely on their contents, sanity-checks via nonfatal 33 // their validity based solely on their contents, sanity-checks via nonfatal
33 // gtest assertions. 34 // gtest assertions.
34 void SanityCheckContext(NativeCPUContext* context) { 35 void SanityCheckContext(NativeCPUContext* context) {
35 #if defined(ARCH_CPU_X86) 36 #if defined(ARCH_CPU_X86)
36 ASSERT_EQ(x86_THREAD_STATE32, context->tsh.flavor); 37 ASSERT_EQ(x86_THREAD_STATE32, context->tsh.flavor);
37 ASSERT_EQ(static_cast<int>(x86_THREAD_STATE32_COUNT), context->tsh.count); 38 ASSERT_EQ(implicit_cast<int>(x86_THREAD_STATE32_COUNT), context->tsh.count);
38 #elif defined(ARCH_CPU_X86_64) 39 #elif defined(ARCH_CPU_X86_64)
39 ASSERT_EQ(x86_THREAD_STATE64, context->tsh.flavor); 40 ASSERT_EQ(x86_THREAD_STATE64, context->tsh.flavor);
40 ASSERT_EQ(static_cast<int>(x86_THREAD_STATE64_COUNT), context->tsh.count); 41 ASSERT_EQ(implicit_cast<int>(x86_THREAD_STATE64_COUNT), context->tsh.count);
41 #endif 42 #endif
42 43
43 #if defined(ARCH_CPU_X86_FAMILY) 44 #if defined(ARCH_CPU_X86_FAMILY)
44 // The segment registers are only capable of storing 16-bit quantities, but 45 // The segment registers are only capable of storing 16-bit quantities, but
45 // the context structure provides native integer-width fields for them. Ensure 46 // the context structure provides native integer-width fields for them. Ensure
46 // that the high bits are all clear. 47 // that the high bits are all clear.
47 // 48 //
48 // Many bit positions in the flags register are reserved and will always read 49 // Many bit positions in the flags register are reserved and will always read
49 // a known value. Most reservd bits are always 0, but bit 1 is always 1. Check 50 // a known value. Most reservd bits are always 0, but bit 1 is always 1. Check
50 // that the reserved bits are all set to their expected values. Note that the 51 // that the reserved bits are all set to their expected values. Note that the
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 EXPECT_GT(ProgramCounterFromContext(&context_2), pc); 139 EXPECT_GT(ProgramCounterFromContext(&context_2), pc);
139 } 140 }
140 141
141 TEST(CaptureContextMac, CaptureContext) { 142 TEST(CaptureContextMac, CaptureContext) {
142 ASSERT_NO_FATAL_FAILURE(TestCaptureContext()); 143 ASSERT_NO_FATAL_FAILURE(TestCaptureContext());
143 } 144 }
144 145
145 } // namespace 146 } // namespace
146 } // namespace test 147 } // namespace test
147 } // namespace crashpad 148 } // namespace crashpad
OLDNEW
« no previous file with comments | « no previous file | client/simple_string_dictionary.h » ('j') | client/simple_string_dictionary.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698