Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 700373005: Check within target process for policy match on registry intercepts (Closed)

Created:
6 years, 1 month ago by Will Harris
Modified:
6 years, 1 month ago
Reviewers:
jschuh
CC:
chromium-reviews, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Check within target process for policy match on registry intercepts before sending to the broker process. BUG= Committed: https://crrev.com/47e8f2fb2b87e23de64d7cf6dec827adb4e1f758 Cr-Commit-Position: refs/heads/master@{#303773}

Patch Set 1 #

Patch Set 2 : func name #

Total comments: 2

Patch Set 3 : nits. fix dcheck #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -0 lines) Patch
M sandbox/win/src/registry_interception.cc View 1 3 chunks +48 lines, -0 lines 0 comments Download
M sandbox/win/src/sandbox_nt_util.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M sandbox/win/src/sandbox_nt_util.cc View 1 2 1 chunk +72 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Will Harris
6 years, 1 month ago (2014-11-06 20:43:20 UTC) #2
jschuh
lgtm with a nit https://codereview.chromium.org/700373005/diff/20001/sandbox/win/src/sandbox_nt_util.cc File sandbox/win/src/sandbox_nt_util.cc (right): https://codereview.chromium.org/700373005/diff/20001/sandbox/win/src/sandbox_nt_util.cc#newcode231 sandbox/win/src/sandbox_nt_util.cc:231: NtQueryObjectFunction NtQueryObject = NULL; I ...
6 years, 1 month ago (2014-11-11 22:16:06 UTC) #3
Will Harris
https://codereview.chromium.org/700373005/diff/20001/sandbox/win/src/sandbox_nt_util.cc File sandbox/win/src/sandbox_nt_util.cc (right): https://codereview.chromium.org/700373005/diff/20001/sandbox/win/src/sandbox_nt_util.cc#newcode231 sandbox/win/src/sandbox_nt_util.cc:231: NtQueryObjectFunction NtQueryObject = NULL; On 2014/11/11 22:16:06, jschuh wrote: ...
6 years, 1 month ago (2014-11-12 00:30:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/700373005/40001
6 years, 1 month ago (2014-11-12 00:32:06 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-12 01:17:09 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 01:17:44 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/47e8f2fb2b87e23de64d7cf6dec827adb4e1f758
Cr-Commit-Position: refs/heads/master@{#303773}

Powered by Google App Engine
This is Rietveld 408576698