Scanner: disallow unicode escapes in regexp flags.

Scanner: disallow unicode escapes in regexp flags.

The spec explicitly forbids them. V8 never handled them properly either, just
the Scanner accepted them (it had code to add them literally to the
LiteralBuffer) and later on, Regexp constructor disallowed them.

According to the spec, unicode escapes in regexp flags should be an early error
("It is a Syntax Error if IdentifierPart contains a Unicode escape sequence.").

Note that Scanner is still more relaxed about regexp flags than the
spec. Especially, it accepts any identifier parts (not just a small set of
letters) and doesn't check for duplicates.

R=rossberg@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=25215

[marja, 2014-11-06 09:09:57]

marja@chromium.org changed reviewers:
+ rossberg@chromium.org

[marja, 2014-11-06 09:10:36]

rossberg, ptal

[rossberg, 2014-11-06 10:45:17]

lgtm

[marja, 2014-11-07 14:03:59]

I had to update a test since \u stuff in flags is now an early error. The update
is pretty trivial so I'm going to go on and assume this LGTY.

(The test is slightly duplicate given what is in test-parsing.cc, so it could be
arguably removed; otoh, it's nice to have "complete" tests too.)

[marja, 2014-11-07 14:32:03]

Committed patchset #2 (id:20001) manually as 25215 (presubmit successful).